summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGwendal Grignou <gwendal@google.com>2021-04-26 12:03:41 -0700
committerCommit Bot <commit-bot@chromium.org>2021-05-19 16:43:06 +0000
commitcd6636048923560f024796c699f17b4c340bbbf4 (patch)
tree0bfd9e707fa3f57b11808f54761e354c4af4c0f9
parent958e53d9cb2e0531eb33a5901e43efa237ffb835 (diff)
downloadchrome-ec-cd6636048923560f024796c699f17b4c340bbbf4.tar.gz
config: Populate CONFIG_SUPPRESSED_HOST_COMMANDS
Commands that are send peridically or in high number are not reported on the console through CONFIG_SUPPRESSED_HOST_COMMANDS variable. Use the same set of commands throughout to avoid misses like newer command EC_CMD_GET_UPTIME_INFO. BUG=none BRANCH=none TEST=buildall Signed-off-by: Gwendal Grignou <gwendal@google.com> Change-Id: I0041576538a8cc659c262118b1503777b9ea8578 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2851452 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Craig Hesling <hesling@chromium.org> Tested-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
Diffstat
-rw-r--r--baseboard/asurada/baseboard.h3
-rw-r--r--baseboard/cherry/baseboard.h3
-rw-r--r--baseboard/dedede/baseboard.h4
-rw-r--r--baseboard/goroh/baseboard.h3
-rw-r--r--baseboard/guybrush/baseboard.h2
-rw-r--r--baseboard/kalista/baseboard.h2
-rw-r--r--baseboard/kukui/baseboard.h2
-rw-r--r--baseboard/nucleo-f412zg/base-board.h2
-rw-r--r--baseboard/nucleo-h743zi/base-board.h2
-rw-r--r--baseboard/octopus/baseboard.h4
-rw-r--r--board/ambassador/board.h3
-rw-r--r--board/dooly/board.h2
-rw-r--r--board/endeavour/board.h2
-rw-r--r--board/fizz/board.h2
-rw-r--r--board/genesis/board.h3
-rw-r--r--board/hatch_fp/board.h2
-rw-r--r--board/kukui_scp/board.h2
-rw-r--r--board/nami/board.h3
-rw-r--r--board/nocturne/board.h3
-rw-r--r--board/nocturne_fp/board.h2
-rw-r--r--board/puff/board.h3
-rw-r--r--board/samus_pd/board.h3
-rw-r--r--include/config.h11
23 files changed, 12 insertions, 56 deletions
diff --git a/baseboard/asurada/baseboard.h b/baseboard/asurada/baseboard.h
index 52d03cced0..242bba54b2 100644
--- a/baseboard/asurada/baseboard.h
+++ b/baseboard/asurada/baseboard.h
@@ -160,9 +160,6 @@
/* SPI / Host Command */
#define CONFIG_SPI
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_MOTION_SENSE_CMD, \
- EC_CMD_PD_GET_LOG_ENTRY
/* MKBP */
#define CONFIG_MKBP_EVENT
diff --git a/baseboard/cherry/baseboard.h b/baseboard/cherry/baseboard.h
index a93ee9f3ef..2510dac5ec 100644
--- a/baseboard/cherry/baseboard.h
+++ b/baseboard/cherry/baseboard.h
@@ -162,9 +162,6 @@
/* SPI / Host Command */
#define CONFIG_SPI
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_MOTION_SENSE_CMD, \
- EC_CMD_PD_GET_LOG_ENTRY
/* MKBP */
#define CONFIG_MKBP_EVENT
diff --git a/baseboard/dedede/baseboard.h b/baseboard/dedede/baseboard.h
index b40b8a6cfe..f7cbfcac31 100644
--- a/baseboard/dedede/baseboard.h
+++ b/baseboard/dedede/baseboard.h
@@ -13,10 +13,6 @@
* The sensor stack is generating a lot of activity.
*/
#define CC_DEFAULT (CC_ALL & ~(CC_MASK(CC_EVENTS) | CC_MASK(CC_LPC)))
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_USB_PD_DISCOVERY,\
- EC_CMD_USB_PD_POWER_INFO, EC_CMD_PD_GET_LOG_ENTRY, \
- EC_CMD_MOTION_SENSE_CMD, EC_CMD_GET_NEXT_EVENT
/*
* Variant EC defines. Pick one:
diff --git a/baseboard/goroh/baseboard.h b/baseboard/goroh/baseboard.h
index d6697ee60e..070ba2dd9e 100644
--- a/baseboard/goroh/baseboard.h
+++ b/baseboard/goroh/baseboard.h
@@ -162,9 +162,6 @@
/* SPI / Host Command */
#define CONFIG_SPI
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_MOTION_SENSE_CMD, \
- EC_CMD_PD_GET_LOG_ENTRY
/* MKBP */
#define CONFIG_MKBP_EVENT
diff --git a/baseboard/guybrush/baseboard.h b/baseboard/guybrush/baseboard.h
index 5f3ec9fd5b..aaaa7f895f 100644
--- a/baseboard/guybrush/baseboard.h
+++ b/baseboard/guybrush/baseboard.h
@@ -112,8 +112,6 @@
#define CONFIG_TABLET_MODE
#define CONFIG_GMR_TABLET_MODE
#define GMR_TABLET_MODE_GPIO_L GPIO_TABLET_MODE
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_MOTION_SENSE_CMD
/* Battery Config */
#define CONFIG_BATTERY_PRESENT_GPIO GPIO_EC_BATT_PRES_ODL
diff --git a/baseboard/kalista/baseboard.h b/baseboard/kalista/baseboard.h
index 7579acd2d7..abccbfe528 100644
--- a/baseboard/kalista/baseboard.h
+++ b/baseboard/kalista/baseboard.h
@@ -54,8 +54,6 @@
#define CONFIG_THROTTLE_AP
#define CONFIG_CHIPSET_CAN_THROTTLE
#define CONFIG_PWM
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
/* EC console commands */
#define CONFIG_CMD_BUTTON
diff --git a/baseboard/kukui/baseboard.h b/baseboard/kukui/baseboard.h
index f4869ce943..83c574eb60 100644
--- a/baseboard/kukui/baseboard.h
+++ b/baseboard/kukui/baseboard.h
@@ -171,8 +171,6 @@
/* By default, set hcdebug to off */
#undef CONFIG_HOSTCMD_DEBUG_MODE
#define CONFIG_HOSTCMD_DEBUG_MODE HCDEBUG_OFF
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_MOTION_SENSE_CMD
#define CONFIG_LTO
#define CONFIG_POWER_BUTTON
diff --git a/baseboard/nucleo-f412zg/base-board.h b/baseboard/nucleo-f412zg/base-board.h
index 31b4a73131..d41cdfd207 100644
--- a/baseboard/nucleo-f412zg/base-board.h
+++ b/baseboard/nucleo-f412zg/base-board.h
@@ -169,8 +169,6 @@
#define CONFIG_SHA256
#define CONFIG_SHA256_UNROLLED
#define CONFIG_STM_HWTIMER32
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
#define CONFIG_WP_ACTIVE_HIGH
#ifndef TEST_BUILD
diff --git a/baseboard/nucleo-h743zi/base-board.h b/baseboard/nucleo-h743zi/base-board.h
index 52744da323..df5e4bfa8c 100644
--- a/baseboard/nucleo-h743zi/base-board.h
+++ b/baseboard/nucleo-h743zi/base-board.h
@@ -100,8 +100,6 @@
#undef CONFIG_SHAREDLIB_SIZE
#define CONFIG_SHAREDLIB_SIZE 0
#define CONFIG_STM_HWTIMER32
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
#define CONFIG_WATCHDOG_HELP
#define CONFIG_WP_ACTIVE_HIGH
diff --git a/baseboard/octopus/baseboard.h b/baseboard/octopus/baseboard.h
index 1d580b233f..c729b84bf8 100644
--- a/baseboard/octopus/baseboard.h
+++ b/baseboard/octopus/baseboard.h
@@ -17,10 +17,6 @@
* The sensor stack is generating a lot of activity.
*/
#define CC_DEFAULT (CC_ALL & ~(CC_MASK(CC_EVENTS) | CC_MASK(CC_LPC)))
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_USB_PD_DISCOVERY,\
- EC_CMD_USB_PD_POWER_INFO, EC_CMD_PD_GET_LOG_ENTRY, \
- EC_CMD_MOTION_SENSE_CMD, EC_CMD_GET_NEXT_EVENT
/*
* Variant EC defines. Pick one:
diff --git a/board/ambassador/board.h b/board/ambassador/board.h
index 52412b4bfe..ea9a05474e 100644
--- a/board/ambassador/board.h
+++ b/board/ambassador/board.h
@@ -49,9 +49,6 @@
#define CONFIG_VSTORE_SLOT_COUNT 1
#define CONFIG_SHA256
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
-
/* EC Commands */
#define CONFIG_CMD_BUTTON
/* Include CLI command needed to support CCD testing. */
diff --git a/board/dooly/board.h b/board/dooly/board.h
index 51259c006b..120afbb865 100644
--- a/board/dooly/board.h
+++ b/board/dooly/board.h
@@ -84,8 +84,6 @@
#define CONFIG_VSTORE_SLOT_COUNT 1
#define CONFIG_SHA256
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
/* EC Commands */
#define CONFIG_CMD_BUTTON
diff --git a/board/endeavour/board.h b/board/endeavour/board.h
index eca98dad6d..a8ed940db1 100644
--- a/board/endeavour/board.h
+++ b/board/endeavour/board.h
@@ -49,8 +49,6 @@
#define CONFIG_THROTTLE_AP
#define CONFIG_CHIPSET_CAN_THROTTLE
#define CONFIG_PWM
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
/* EC console commands */
#define CONFIG_CMD_BUTTON
diff --git a/board/fizz/board.h b/board/fizz/board.h
index 160680edb6..269fa883ed 100644
--- a/board/fizz/board.h
+++ b/board/fizz/board.h
@@ -57,8 +57,6 @@
#define CONFIG_THROTTLE_AP
#define CONFIG_CHIPSET_CAN_THROTTLE
#define CONFIG_PWM
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
/* EC console commands */
#define CONFIG_CMD_BUTTON
diff --git a/board/genesis/board.h b/board/genesis/board.h
index b380ac28f9..a848f67e86 100644
--- a/board/genesis/board.h
+++ b/board/genesis/board.h
@@ -49,9 +49,6 @@
#define CONFIG_VSTORE_SLOT_COUNT 1
#define CONFIG_SHA256
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
-
/* EC Commands */
#define CONFIG_CMD_BUTTON
/* Include CLI command needed to support CCD testing. */
diff --git a/board/hatch_fp/board.h b/board/hatch_fp/board.h
index 9f2278c47c..ea9df71257 100644
--- a/board/hatch_fp/board.h
+++ b/board/hatch_fp/board.h
@@ -236,8 +236,6 @@
#define CONFIG_SHA256_UNROLLED
#define CONFIG_SPI
#define CONFIG_STM_HWTIMER32
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
#define CONFIG_WP_ACTIVE_HIGH
#ifndef __ASSEMBLER__
diff --git a/board/kukui_scp/board.h b/board/kukui_scp/board.h
index 040a7a0b9f..4847cdf939 100644
--- a/board/kukui_scp/board.h
+++ b/board/kukui_scp/board.h
@@ -79,8 +79,6 @@
#define IPI_NS_SERVICE 0xFF
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ
#undef CONFIG_UART_TX_BUF_SIZE
#define CONFIG_UART_TX_BUF_SIZE 8192
diff --git a/board/nami/board.h b/board/nami/board.h
index 04cf4768a8..c2f90f821a 100644
--- a/board/nami/board.h
+++ b/board/nami/board.h
@@ -58,9 +58,6 @@
#define CONFIG_FAN_DYNAMIC
#define CONFIG_THROTTLE_AP
#define CONFIG_PWM_KBLIGHT
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY, \
- EC_CMD_MOTION_SENSE_CMD
/* EC console commands */
#define CONFIG_CMD_ACCELS
diff --git a/board/nocturne/board.h b/board/nocturne/board.h
index a009cc118a..b1d750f14f 100644
--- a/board/nocturne/board.h
+++ b/board/nocturne/board.h
@@ -16,9 +16,6 @@
#undef CONFIG_HOSTCMD_DEBUG_MODE
#define CONFIG_HOSTCMD_DEBUG_MODE HCDEBUG_OFF
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
-
/* NPCX7 config */
#define NPCX_UART_MODULE2 1 /* GPIO64/65 are used as UART pins. */
#define NPCX_TACH_SEL2 0 /* No tach. */
diff --git a/board/nocturne_fp/board.h b/board/nocturne_fp/board.h
index 085df8dceb..ece1b64258 100644
--- a/board/nocturne_fp/board.h
+++ b/board/nocturne_fp/board.h
@@ -106,8 +106,6 @@
#define CONFIG_SHA256_UNROLLED
#define CONFIG_SPI
#define CONFIG_STM_HWTIMER32
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
#undef CONFIG_TASK_PROFILING
#define CONFIG_WATCHDOG_HELP
#define CONFIG_WP_ACTIVE_HIGH
diff --git a/board/puff/board.h b/board/puff/board.h
index 11d6deaae3..c8cc272499 100644
--- a/board/puff/board.h
+++ b/board/puff/board.h
@@ -49,9 +49,6 @@
#define CONFIG_VSTORE_SLOT_COUNT 1
#define CONFIG_SHA256
-#define CONFIG_SUPPRESSED_HOST_COMMANDS \
- EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY
-
/* EC Commands */
#define CONFIG_CMD_BUTTON
/* Include CLI command needed to support CCD testing. */
diff --git a/board/samus_pd/board.h b/board/samus_pd/board.h
index 6f7b78c6f6..287d4df07d 100644
--- a/board/samus_pd/board.h
+++ b/board/samus_pd/board.h
@@ -15,6 +15,9 @@
#undef CONFIG_UART_CONSOLE
#define CONFIG_UART_CONSOLE 1
+/* To save space */
+#undef CONFIG_SUPPRESSED_HOST_COMMANDS
+
/* Optional features */
#define CONFIG_ADC
#undef CONFIG_ADC_WATCHDOG
diff --git a/include/config.h b/include/config.h
index 79bbce9c62..3f25fca6f3 100644
--- a/include/config.h
+++ b/include/config.h
@@ -2325,8 +2325,15 @@
/* Command to get the EC uptime (and optionally AP reset stats) */
#define CONFIG_HOSTCMD_GET_UPTIME_INFO
-/* List of host commands whose debug output will be suppressed */
-#undef CONFIG_SUPPRESSED_HOST_COMMANDS
+/*
+ * List of host commands whose debug output will be suppressed
+ * By default remove periodic commands and commands called often (SENSE).
+ */
+#define CONFIG_SUPPRESSED_HOST_COMMANDS \
+ EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_USB_PD_DISCOVERY, \
+ EC_CMD_USB_PD_POWER_INFO, EC_CMD_PD_GET_LOG_ENTRY, \
+ EC_CMD_MOTION_SENSE_CMD, EC_CMD_GET_NEXT_EVENT, EC_CMD_GET_UPTIME_INFO
+
/*****************************************************************************/
View Lorry Controller Status