summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevin Lu <Devin.Lu@quantatw.com>2021-12-24 15:56:16 +0800
committerCommit Bot <commit-bot@chromium.org>2021-12-30 03:22:57 +0000
commitb566adf633b2f1ec562dd94ce6e4503c531657a5 (patch)
treed3ac4bd70c70f60c01d60f3549e48dbc17a8f560
parent7d13a7a0fde8c2ff82b98b150b3608895ae226e8 (diff)
downloadchrome-ec-b566adf633b2f1ec562dd94ce6e4503c531657a5.tar.gz
vell: Tuning TCPC reset timing
BUG=b:203371200 BRANCH=none TEST=Verify boot from dead battery mode, Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Change-Id: Ia01a812f1a42fcc50336aa55a6854ffc86b682a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3354786 Reviewed-by: caveh jalali <caveh@chromium.org>
-rw-r--r--board/vell/usbc_config.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/board/vell/usbc_config.c b/board/vell/usbc_config.c
index 6a81f04bb5..eca6782ba4 100644
--- a/board/vell/usbc_config.c
+++ b/board/vell/usbc_config.c
@@ -299,25 +299,25 @@ __override int bb_retimer_power_enable(const struct usb_mux *me, bool enable)
void board_reset_pd_mcu(void)
{
- /*
- * TODO(b/203371200): figure out correct timing
- */
-
gpio_set_level(GPIO_USB_C0_C1_TCPC_RST_ODL, 0);
gpio_set_level(GPIO_USB_C2_C3_TCPC_RST_ODL, 0);
/*
* delay for power-on to reset-off and min. assertion time
*/
-
- msleep(20);
+ msleep(NCT38XX_RESET_HOLD_DELAY_MS);
gpio_set_level(GPIO_USB_C0_C1_TCPC_RST_ODL, 1);
gpio_set_level(GPIO_USB_C2_C3_TCPC_RST_ODL, 1);
- /* wait for chips to come up */
+ nct38xx_reset_notify(USBC_PORT_C0);
+ nct38xx_reset_notify(USBC_PORT_C1);
+ nct38xx_reset_notify(USBC_PORT_C2);
+ nct38xx_reset_notify(USBC_PORT_C3);
- msleep(50);
+ /* wait for chips to come up */
+ if (NCT3808_RESET_POST_DELAY_MS != 0)
+ msleep(NCT3808_RESET_POST_DELAY_MS);
}
static void board_tcpc_init(void)