diff options
| author | Mike Lee <mike5@huaqin.corp-partner.google.com> | 2021-12-20 02:55:04 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-01-06 04:43:13 +0000 |
| commit | b23c9708fe7ac977b8f4096622fc241b36f619c7 (patch) | |
| tree | ed45585a18b3c205ced643476ba9356b57a81931 | |
| parent | 2bd7f1275354f4a270df44d9b9d8a156eb73d0ae (diff) | |
| download | chrome-ec-b23c9708fe7ac977b8f4096622fc241b36f619c7.tar.gz | |
Revert "Storo: Modify active charge port setting"
This reverts commit abc448dfbb68b8b94fbfaf1e8193d44b44cf1107.
Reason for revert: sinking must always be re-enabled during
the hard reset process, and due to timing differences, we may
not always go through the charge port of None in this sequence
Original change's description:
> Storo: Modify active charge port setting
>
> If the port is not changing, should not be doing anything.
> In order to solve the problem of sometimes unable to boot
> under AC only state, we can make a return early.
>
> BUG=b:197199689
> BRANCH=dedede
> TEST=make BOARD=storo pass, the DUT can boot up normally
> when only the 45W adapter is inserted
>
> Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
> Change-Id: Icec7a5e9a0ed6efdd41489b4fd3e74325f4b81fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3167617
> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
> Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Bug: b:197199689,b:211080520
Change-Id: I21c34e7616e3797dba5c3c77f7591a37f19f3981
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3347352
Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Tested-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Mike Lee <mike5@huaqin.corp-partner.google.com>
| -rw-r--r-- | board/storo/board.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/board/storo/board.c b/board/storo/board.c index f864d230c2..7ea3cbceac 100644 --- a/board/storo/board.c +++ b/board/storo/board.c @@ -462,10 +462,6 @@ int board_set_active_charge_port(int port) old_port = charge_manager_get_active_charge_port(); - /* If the port is not changing, we should do nothing */ - if (old_port == port) - return EC_SUCCESS; - CPRINTS("New chg p%d", port); /* Disable all ports. */ |