summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2022-01-14 13:01:58 -0700
committerCommit Bot <commit-bot@chromium.org>2022-01-21 19:37:31 +0000
commit71efe4989c253562b555c00b92cbe37487a8dacc (patch)
treef6088737713e0fd5183413d4d63f261ca034d025
parente58883fa4e314bbf6c9f1d6ca7a88c7505df27fe (diff)
downloadchrome-ec-71efe4989c253562b555c00b92cbe37487a8dacc.tar.gz
Revert "make: disable kconfig option check"
Unfortunately this was disabled but never restarted. We have a number of CONFIG options that are missing Kconfigs: For volteer the list is: CONFIG_BATTERY_LOW_VOLTAGE_TIMEOUT CONFIG_HOSTCMD_DEBUG_MODE CONFIG_LED_PWM_COUNT CONFIG_POWER_S4_RESIDENCY CONFIG_STEINHART_HART_3V3_30K9_47K_4050B CONFIG_USB_PD_FLAGS This cannot be applied until the above are fixed. Possibly this is not a big problem anymore, since we are likely not adding much new functionality to ECOS. This reverts commit b3f5db5be78e15290dc7d80eaeecbb0f1b754a2c BUG=b:195718112 BRANCH=none TEST=make buildall -j32 Change-Id: I4b148caa04509721db83d001eb65dc061b2f21a6 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3388360 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
-rw-r--r--Makefile.rules5
1 files changed, 1 insertions, 4 deletions
diff --git a/Makefile.rules b/Makefile.rules
index 8f2d2994e5..9808fa712d 100644
--- a/Makefile.rules
+++ b/Makefile.rules
@@ -246,10 +246,7 @@ ifeq ($(TEST_BUILD),)
@echo "directory! Otherwise, you won't be able to enter any commands."
endif # not a TEST_BUILD
endif # CONFIG_EXPERIMENTAL_CONSOLE=y
-# TODO(b/195718112): Disable config option check as it's
-# suspected to be breaking the CQ. We should consider enabling
-# as a pre-submit only when re-enabling.
-# $(call quiet,check_allowed)
+ $(call quiet,check_allowed)
proj-%: | $(FAILED_BOARDS_DIR)
@touch $(FAILED_BOARDS_DIR)/$*