diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2022-02-01 16:56:27 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-02-02 21:51:35 +0000 |
| commit | b5662a52ae10cd6bde8c6a9c9df9d49116084640 (patch) | |
| tree | 1e43f9515914a8972f72816eb1049348881ad400 | |
| parent | 031983d42c412414709bf3e83adda501348043f5 (diff) | |
| download | chrome-ec-b5662a52ae10cd6bde8c6a9c9df9d49116084640.tar.gz | |
TCPMv2: Do not skip cable reset during Data Reset
Do not set PE_FLAGS_DATA_RESET_COMPLETE during
pe_ddr_perform_data_reset_entry. In the case where the TCPM is not the
initial VCONN Source, VCONN should already have been turned off.
However, wait until the TC has completed turning it back on before
considering Data Reset complete at the PE level.
BUG=b:209625351,b:209624473
TEST=Attach Voxel to Godzilla Creek; successful mode entry after Data
Reset with Godzilla Creek as initial VCONN Source
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Idecc964ad1252174db90854dfad43abfaa6ad113
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3430307
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 60a2255215..4f12675fe2 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -7174,8 +7174,6 @@ static void pe_ddr_perform_data_reset_entry(int port) */ if (IS_ENABLED(CONFIG_USBC_VCONN) && tc_is_vconn_src(port)) pd_request_vconn_swap_off(port); - else - PE_SET_FLAG(port, PE_FLAGS_DATA_RESET_COMPLETE); } static void pe_ddr_perform_data_reset_run(int port) |