diff options
| author | Patryk Duda <pdk@semihalf.com> | 2020-12-29 14:30:29 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-04 15:30:43 +0000 |
| commit | 599adce080bb194fc69e0a7243ba6b39dc707390 (patch) | |
| tree | 6e7f9113d8b308854f6d4cfb8f5cd4952b21c930 | |
| parent | 29c942404c1bddc0da5c04caf1e1a6dc4425cd4f (diff) | |
| download | chrome-ec-599adce080bb194fc69e0a7243ba6b39dc707390.tar.gz | |
TCPMv2: Add information about port when printing flag and event names
This CL modifies print_bits() function to provide port number while
printing flag names. Without this it is not clear to which port flag
change is applied.
BUG=b:161775827
BRANCH=none
TEST=Define DEBUG_PRINT_FLAG_AND_EVENT_NAMES, check if messages
contain information about port.
Signed-off-by: Patryk Duda <pdk@semihalf.com>
Change-Id: I2124bdafa32651b5b87ba78cf367d5c39000b708
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2606234
Reviewed-by: Edward Hill <ecgh@chromium.org>
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 655d291dbb..1df7710301 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -60,15 +60,15 @@ #undef DEBUG_PRINT_FLAG_AND_EVENT_NAMES #ifdef DEBUG_PRINT_FLAG_AND_EVENT_NAMES -void print_flag(int set_or_clear, int flag); +void print_flag(int port, int set_or_clear, int flag); #define TC_SET_FLAG(port, flag) \ do { \ - print_flag(1, flag); \ + print_flag(port, 1, flag); \ atomic_or(&tc[port].flags, (flag)); \ } while (0) #define TC_CLR_FLAG(port, flag) \ do { \ - print_flag(0, flag); \ + print_flag(port, 0, flag); \ atomic_clear_bits(&tc[port].flags, (flag)); \ } while (0) #else @@ -325,12 +325,12 @@ static struct bit_name event_bit_names[] = { { PD_EVENT_SYSJUMP, "SYSJUMP" }, }; -static void print_bits(const char *desc, int value, +static void print_bits(int port, const char *desc, int value, struct bit_name *names, int names_size) { int i; - CPRINTF("%s 0x%x : ", desc, value); + CPRINTF("C%d: %s 0x%x : ", port, desc, value); for (i = 0; i < names_size; i++) { if (value & names[i].value) CPRINTF("%s | ", names[i].name); @@ -341,9 +341,9 @@ static void print_bits(const char *desc, int value, CPRINTF("\n"); } -void print_flag(int set_or_clear, int flag) +void print_flag(int port, int set_or_clear, int flag) { - print_bits(set_or_clear ? "Set" : "Clr", flag, flag_bit_names, + print_bits(port, set_or_clear ? "Set" : "Clr", flag, flag_bit_names, ARRAY_SIZE(flag_bit_names)); } #endif /* DEBUG_PRINT_FLAG_AND_EVENT_NAMES */ @@ -1551,7 +1551,7 @@ void tc_event_check(int port, int evt) { #ifdef DEBUG_PRINT_FLAG_AND_EVENT_NAMES if (evt != TASK_EVENT_TIMER) - print_bits("Event", evt, event_bit_names, + print_bits(port, "Event", evt, event_bit_names, ARRAY_SIZE(event_bit_names)); #endif |