summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDawid Niedzwiecki <dn@semihalf.com>2022-02-11 09:41:33 +0100
committerCommit Bot <commit-bot@chromium.org>2022-02-18 21:55:58 +0000
commit5a21aa1779e526d4506658890f9d440d0ce294b2 (patch)
treeba3c88b1963b36f58c483b5ee0d084f5e4f9035e
parentdb890af461cdaff8249248095e25758e7045fce6 (diff)
downloadchrome-ec-5a21aa1779e526d4506658890f9d440d0ce294b2.tar.gz
zephyr: cbi: use alias for GPIO_EC_CBI_WP
Start using an alias instead of legacy enum-name property for CBI WP output pin. BUG=b:211779766 TEST=zmake testall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Icc0f496c16d36809896ba66ace9979155648578a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3455465 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
-rw-r--r--zephyr/projects/skyrim/skyrim.dts3
-rw-r--r--zephyr/shim/src/cbi_eeprom.c6
2 files changed, 7 insertions, 2 deletions
diff --git a/zephyr/projects/skyrim/skyrim.dts b/zephyr/projects/skyrim/skyrim.dts
index b747aed6a0..f21c147804 100644
--- a/zephyr/projects/skyrim/skyrim.dts
+++ b/zephyr/projects/skyrim/skyrim.dts
@@ -6,6 +6,7 @@
/ {
aliases {
gpio-wp = &gpio_wp;
+ gpio-cbi-wp = &gpio_cbi_wp;
};
named-gpios {
@@ -70,7 +71,7 @@
ec_sc_rst {
gpios = <&gpiob 0 GPIO_OUT_LOW>;
};
- ec_cbi_wp {
+ gpio_cbi_wp: ec_cbi_wp {
gpios = <&gpio8 1 GPIO_OUT_LOW>;
};
gpio_wp: ec_wp_l {
diff --git a/zephyr/shim/src/cbi_eeprom.c b/zephyr/shim/src/cbi_eeprom.c
index a879053b99..5603b1c63a 100644
--- a/zephyr/shim/src/cbi_eeprom.c
+++ b/zephyr/shim/src/cbi_eeprom.c
@@ -12,10 +12,14 @@
#define CBI_EEPROM_DEV DEVICE_DT_GET(DT_NODELABEL(cbi_eeprom))
#ifdef CONFIG_PLATFORM_EC_EEPROM_CBI_WP
+#if !DT_NODE_EXISTS(DT_ALIAS(gpio_cbi_wp))
+#error gpio_cbi_wp alias has to point to the CBI WP output pin.
+#endif
+
void cbi_latch_eeprom_wp(void)
{
cprints(CC_SYSTEM, "CBI WP latched");
- gpio_pin_set_dt(GPIO_DT_FROM_ALIAS(gpio_wp), 1);
+ gpio_pin_set_dt(GPIO_DT_FROM_ALIAS(gpio_cbi_wp), 1);
}
#endif /* CONFIG_PLATFORM_EC_EEPROM_CBI_WP */