summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Short <keithshort@chromium.org>2022-02-11 15:46:24 -0700
committerCommit Bot <commit-bot@chromium.org>2022-02-25 21:08:43 +0000
commite420fea291a6fed8c5d5a237e1f07cbece74a57d (patch)
tree0a0f7128343d73f550966f5a4cb3b1f0fc184525
parentd197a82baaa0a637531d68774f8f11bd20407b60 (diff)
downloadchrome-ec-e420fea291a6fed8c5d5a237e1f07cbece74a57d.tar.gz
gpio: cleanup header usage for chipset task
chipset.h only requires the enum gpio_signal, so use gpio_signal.h instead of gpio.h. The build doesn't compare due to an ASSERT() call in throttle_ap.c after the number of lines increased by 1. From prochot_input_deferred() before the change: 1009b592: 2158 movs r1, #88 ; 0x58 1009b594: f7fd ff76 bl 10099484 <panic_assert_fail> After the change 1009b592: 2159 movs r1, #89 ; 0x59 1009b594: f7fd ff76 bl 10099484 <panic_assert_fail> BUG=b:218856245 BRANCH=none TEST=compare_build.sh Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I30dcdec6985d51279512c25889f03b5f9b1955e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489093 Reviewed-by: Tristan Honscheid <honscheid@google.com>
-rw-r--r--board/drawcia/led.c1
-rw-r--r--board/drawcia_riscv/led.c1
-rw-r--r--board/haboki/led.c1
-rw-r--r--board/lantis/led.c1
-rw-r--r--board/morphius/thermal.c1
-rw-r--r--board/scarlet/led.c1
-rw-r--r--common/throttle_ap.c1
-rw-r--r--include/chipset.h2
8 files changed, 8 insertions, 1 deletions
diff --git a/board/drawcia/led.c b/board/drawcia/led.c
index 42518c71fc..ed22fc29ba 100644
--- a/board/drawcia/led.c
+++ b/board/drawcia/led.c
@@ -8,6 +8,7 @@
#include "cbi_fw_config.h"
#include "charge_state.h"
#include "extpower.h"
+#include "gpio.h"
#include "hooks.h"
#include "led_common.h"
diff --git a/board/drawcia_riscv/led.c b/board/drawcia_riscv/led.c
index eb93a0ee82..d13862cdcd 100644
--- a/board/drawcia_riscv/led.c
+++ b/board/drawcia_riscv/led.c
@@ -8,6 +8,7 @@
#include "cbi_fw_config.h"
#include "charge_state.h"
#include "extpower.h"
+#include "gpio.h"
#include "hooks.h"
#include "led_common.h"
diff --git a/board/haboki/led.c b/board/haboki/led.c
index 851124bfde..3e3a61edc2 100644
--- a/board/haboki/led.c
+++ b/board/haboki/led.c
@@ -8,6 +8,7 @@
#include "cbi_fw_config.h"
#include "charge_state.h"
#include "extpower.h"
+#include "gpio.h"
#include "hooks.h"
#include "led_common.h"
diff --git a/board/lantis/led.c b/board/lantis/led.c
index fb5406b252..57d537cf13 100644
--- a/board/lantis/led.c
+++ b/board/lantis/led.c
@@ -9,6 +9,7 @@
#include "charge_manager.h"
#include "charge_state.h"
#include "extpower.h"
+#include "gpio.h"
#include "hooks.h"
#include "led_common.h"
diff --git a/board/morphius/thermal.c b/board/morphius/thermal.c
index 329157b6ec..a51dee7c8b 100644
--- a/board/morphius/thermal.c
+++ b/board/morphius/thermal.c
@@ -8,6 +8,7 @@
#include "console.h"
#include "extpower.h"
#include "fan.h"
+#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
#include "lid_switch.h"
diff --git a/board/scarlet/led.c b/board/scarlet/led.c
index d4c758cdcc..d327ee46d6 100644
--- a/board/scarlet/led.c
+++ b/board/scarlet/led.c
@@ -8,6 +8,7 @@
#include "battery.h"
#include "charge_state.h"
#include "chipset.h"
+#include "gpio.h"
#include "hooks.h"
#include "led_common.h"
#include "lid_switch.h"
diff --git a/common/throttle_ap.c b/common/throttle_ap.c
index cfa97d93a5..6d794916ae 100644
--- a/common/throttle_ap.c
+++ b/common/throttle_ap.c
@@ -9,6 +9,7 @@
#include "common.h"
#include "console.h"
#include "dptf.h"
+#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
#include "task.h"
diff --git a/include/chipset.h b/include/chipset.h
index 8f242624a6..c0aad511de 100644
--- a/include/chipset.h
+++ b/include/chipset.h
@@ -16,7 +16,7 @@
#include "common.h"
#include "compile_time_macros.h"
#include "ec_commands.h"
-#include "gpio.h"
+#include "gpio_signal.h"
#include "stddef.h"
/*