diff options
| author | Caveh Jalali <caveh@chromium.org> | 2018-05-03 17:49:48 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-05-08 01:21:59 -0700 |
| commit | 0f9a4fba96dbef6755a21c96eabf445075b182ef (patch) | |
| tree | 992700dd629a71d308b7cd457722b8c92a513ef7 | |
| parent | 6e8cbe40eea777aeaeffe0fa0781a0a5d1763a4d (diff) | |
| download | chrome-ec-0f9a4fba96dbef6755a21c96eabf445075b182ef.tar.gz | |
charger: set PPVAR_SYS to normal battery voltage
the isl9238 needs to see a higher PPVAR_SYS voltage than we were using
to avoid tripping Low_VSYS. Low_VSYS is one of the terms causing the
isl9238 to assert PROCHOT. its lowest default voltage threshold is
about 6.1v which is too close to the battery "minimum" that we were
using to set PPVAR_SYS. it's better to use the "normal" battery
voltage so the running-on-AC case is similar to the running-on-battery
case.
BUG=b:78911901
BRANCH=none
TEST=examined isl9238 regs to verify it is no longer tripping Low_VSYS
Change-Id: Iafc39e988a5af668c6cc1b5485841f6d659b1e8b
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1043456
Commit-Ready: Caveh Jalali <caveh@google.com>
Tested-by: Caveh Jalali <caveh@google.com>
Tested-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Caveh Jalali <caveh@google.com>
| -rw-r--r-- | common/charge_state_v2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/charge_state_v2.c b/common/charge_state_v2.c index 884daef387..514e3add92 100644 --- a/common/charge_state_v2.c +++ b/common/charge_state_v2.c @@ -1144,7 +1144,7 @@ static int charge_request(int voltage, int current) if (is_full) voltage = battery_get_info()->voltage_max; /* And handle dead battery case */ - voltage = MAX(voltage, battery_get_info()->voltage_min); + voltage = MAX(voltage, battery_get_info()->voltage_normal); #else voltage = current = 0; #endif |