diff options
| author | Scott Chao <scott_chao@wistron.corp-partner.google.com> | 2022-03-17 23:54:49 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-03-22 03:33:24 +0000 |
| commit | df6b4b49ab1beb782a13e18b9e9f26795a25df8b (patch) | |
| tree | 9b0f4cc02a8b86684978da355d1151fb4c4379b5 | |
| parent | 57b31e765bcd3b914174054fbf06f4a489a57b9e (diff) | |
| download | chrome-ec-df6b4b49ab1beb782a13e18b9e9f26795a25df8b.tar.gz | |
gimble: remove obsolete C1 reset configuration
This problem was fixed by PS8815 FW version 0x3. And we are now using
0x25.
BUG=b:223315425
TEST=Check with Parade
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: Ifc554ed750b1e886efe741396f6cf45bc13a1e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3533299
Tested-by: Peter Chi <peter_chi@wistron.corp-partner.google.com>
Reviewed-by: Boris Mittelberg <bmbm@google.com>
| -rw-r--r-- | board/gimble/usbc_config.c | 25 |
1 files changed, 1 insertions, 24 deletions
diff --git a/board/gimble/usbc_config.c b/board/gimble/usbc_config.c index fb807299a6..3aa7c9ee96 100644 --- a/board/gimble/usbc_config.c +++ b/board/gimble/usbc_config.c @@ -151,25 +151,6 @@ void config_usb_db_type(void) CPRINTS("Configured USB DB type number is %d", db_type); } -static void ps8815_reset(void) -{ - int val; - - CPRINTS("%s: patching ps8815 registers", __func__); - - if (i2c_read8(I2C_PORT_USB_C1_TCPC, - PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, &val) == EC_SUCCESS) - CPRINTS("ps8815: reg 0x0f was %02x", val); - - if (i2c_write8(I2C_PORT_USB_C1_TCPC, - PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, 0x31) == EC_SUCCESS) - CPRINTS("ps8815: reg 0x0f set to 0x31"); - - if (i2c_read8(I2C_PORT_USB_C1_TCPC, - PS8XXX_I2C_ADDR1_P2_FLAGS, 0x0f, &val) == EC_SUCCESS) - CPRINTS("ps8815: reg 0x0f now %02x", val); -} - void board_reset_pd_mcu(void) { /* Port0 */ @@ -183,13 +164,9 @@ void board_reset_pd_mcu(void) gpio_set_level(GPIO_USB_C0_TCPC_RST_ODL, 1); gpio_set_level(GPIO_USB_C1_RT_RST_R_ODL, 1); + /* wait for chips to come up */ msleep(PS8815_FW_INIT_DELAY_MS); - - /* Port1 */ - ps8815_reset(); - usb_mux_hpd_update(USBC_PORT_C1, USB_PD_MUX_HPD_LVL_DEASSERTED | - USB_PD_MUX_HPD_IRQ_DEASSERTED); } static void board_tcpc_init(void) |