diff options
| author | mike <mike5@huaqin.corp-partner.google.com> | 2022-05-06 15:05:22 +0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-05-13 09:02:34 +0000 |
| commit | 94a506c16a059c4e358c9ccd249df98fd5eeab3c (patch) | |
| tree | 6dd77ba371476954d8cdeff946ddd34714dfdfdc | |
| parent | 072dd385edce46644d7cf84648505d8e35c0cf42 (diff) | |
| download | chrome-ec-94a506c16a059c4e358c9ccd249df98fd5eeab3c.tar.gz | |
storo: Add comments for redriver
NCS8510 and TUSB544 use the same driver and EQ settings,
so add a comment to explain the situation.
BUG=b:230403435
BRANCH=dedede
TEST=none
Signed-off-by: mike <mike5@huaqin.corp-partner.google.com>
Change-Id: I24d1dd9f5d46c81bcbca12c7d9b4ae14d963643b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3632041
Commit-Queue: Marco Chen <marcochen@chromium.org>
Reviewed-by: wen zhang <zhangwen6@huaqin.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>
| -rw-r--r-- | board/storo/board.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/board/storo/board.c b/board/storo/board.c index 280a85fd99..763d317dba 100644 --- a/board/storo/board.c +++ b/board/storo/board.c @@ -235,6 +235,15 @@ enum tusb544_conf { DP_INV }; +/* + * Registers we care about of are all the same between NCS8510 and TUSB544, + * so we leverage the driver of TUSB544 to control both of them. + * + * For EQ settings, these two chips are also almost the same, so we have one + * set of EQ settings here for both of them as well. When you need to modify + * the EQ settings, please make sure that both configurations are correct; + * otherwise you need to separate EQ settings then. + */ static int board_tusb544_set(const struct usb_mux *me, mux_state_t mux_state) { int rv = EC_SUCCESS; |