summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Hughes <tomhughes@chromium.org>2022-06-02 16:06:53 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-06-09 00:42:14 +0000
commit60032a8828801a316bdcb5f246ebb58da6e529f0 (patch)
tree3553d9ccb6c2038e0c7fe585270c6b502157fcac
parentf40490f84a0a0d080e41f4fb9c954715c2696073 (diff)
downloadchrome-ec-60032a8828801a316bdcb5f246ebb58da6e529f0.tar.gz
docs/fingerprint: Clean up formatting in fingerprint-factory-quick-guide.md
BRANCH=none BUG=b:234772776 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0a107a379367712d79a959dc40b4e6b215be8c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3687544 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Andrea Grandi <agrandi@google.com>
-rw-r--r--docs/fingerprint/fingerprint-factory-quick-guide.md53
1 files changed, 26 insertions, 27 deletions
diff --git a/docs/fingerprint/fingerprint-factory-quick-guide.md b/docs/fingerprint/fingerprint-factory-quick-guide.md
index a2dd69ebe4..0e095bf9fe 100644
--- a/docs/fingerprint/fingerprint-factory-quick-guide.md
+++ b/docs/fingerprint/fingerprint-factory-quick-guide.md
@@ -13,48 +13,44 @@ FPMCU firmware must be flashed before fingerprint functional test is run. ODM
partners may work with the module house to preflash FPMCU firmware before
factory SMT. However, this way ODM partners have to coordinate with the module
house to make sure the preflash FPMCU firmware blob is extracted from the FSI
-release image (from /opt/google/biod/fw/). If the FPMCU firmware doesn’t match
+release image (from `/opt/google/biod/fw/`). If the FPMCU firmware doesn’t match
the FPMCU firmware blob checked into the release image, the end users will see
the ‘critical update’ screen in their out-of-box experience, because
-bio\_fw\_updater tries to update FPMCU firmware at boot time. This is a bad user
+`bio_fw_updater` tries to update FPMCU firmware at boot time. This is a bad user
experience we want to avoid. Most importantly, in PVT/MP build, only the FPMCU
firmware in the release image would be signed by MP key. So you **MUST** ensure
FPMCU is flashed with the MP-signed firmware blob extracted from FSI, before
shipping the devices.
As opposed to pre-flashing FPMCU in the module house, ODM partners are
-encouraged to make use of
-[update\_fpmcu\_firmware.py](https://chromium.googlesource.com/chromiumos/platform/factory/+/e5e903d0a0d8327dd8b9e47d2c808fd845ed73a4/py/test/pytests/update_fpmcu_firmware.py)
-to update FPMCU firmware in the factory flow. This script can detect fingerprint
-MCU board name, find the right FPMCU firmware blob for the DUT from the release
-partition, and then flash FPMCU by flash\_fp\_mcu tool. Please note that this
-script may take more than 30 secs to complete, which is slow.
-
-Since bio\_fw\_update has been disabled in factory test image via
+encouraged to make use of [`update_fpmcu_firmware.py`] to update FPMCU firmware
+in the factory flow. This script can detect fingerprint MCU board name, find the
+right FPMCU firmware blob for the DUT from the release partition, and then flash
+FPMCU by [`flash_fp_mcu`] tool. Please note that this script may take more than
+30 secs to complete, which is slow.
+
+Since `bio_fw_updater` has been disabled in factory test image via
[crrev/c/1913645](https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1913645),
in the factory flow, the FPMCU firmware should not be overwritten by
-boot-update-firmware service during reboot.
+`boot-update-firmware` service during reboot.
### Run fingerprint sensor functional test
-Please add
-[fingerprint\_mcu.py](https://chromium.git.corp.google.com/chromiumos/platform/factory/+/a283609cd8446ba4a4b75c2e1d84c9ba24ea8422/py/test/pytests/fingerprint_mcu.py)
-to your device test list. A more detailed description about this test can be
-found
-[here](https://chromium.googlesource.com/chromiumos/platform/ec/+/HEAD/docs/fingerprint/fingerprint-factory-requirements.md).
+Please add [`fingerprint_mcu.py`] to your device test list. A more detailed
+description about this test can be found [here][factory requirements].
### Initialize FPMCU entropy in factory finalization
The support for FPMCU entropy initialization has been integrated into the
factory finalization script. So FPMCU entropy should be automatically
initialized in factory finalization, if a FPMCU is found on DUT. Note that FPMCU
-entropy initialization would fail if rollback\_block\_id is not equal to zero,
+entropy initialization would fail if `rollback_block_id` is not equal to zero,
which means the entropy has been initialized before. It is usually caused by
-biod trying to initialize FPMCU entropy and increment rollback\_block\_id at
-boot time. Since we have disabled biod and bio\_crypto\_init in factory test
+biod trying to initialize FPMCU entropy and increment `rollback_block_id` at
+boot time. Since we have disabled biod and `bio_crypto_init` in factory test
image via
[crrev/c/1910290](https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1910290),
-we expect rollback\_block\_id would stay zero during the factory flow, and FPMCU
+we expect `rollback_block_id` would stay zero during the factory flow, and FPMCU
entropy initialization should succeed in factory finalization. So just run
factory finalization as any other CrOS boards.
@@ -62,8 +58,8 @@ factory finalization as any other CrOS boards.
The support for FPMCU SWWP has been integrated into factory finalization script.
So FPMCU SWWP should be automatically enabled in factory finalization together
-with AP/EC SWWP when write\_protection arg is set to true and a FPMCU is found
-on DUT. Just run factory finalization as any other CrOS boards.
+with AP/EC SWWP when `write_protection` arg is set to `true` and a FPMCU is
+found on DUT. Just run factory finalization as any other CrOS boards.
### Reset entropy for factory re-finalization (in case of RMA or OQC)
@@ -71,14 +67,12 @@ For the boards that have been finalized, FPMCU entropy has been initialized. So
running re-finalization for those boards are expected to fail at FPMCU entropy
initialization. Before running re-finalization for those boards, ODM partners
have to remove hardware write protection (HWWP) and then run
-[update\_fpmcu\_firmware.py](https://chromium.googlesource.com/chromiumos/platform/factory/+/d399a0a1bdeb7249de2721b269e7365e4486e23c/py/test/pytests/update_fpmcu_firmware.py)
-to reset rollback\_block\_id and entropy. So the follow-up re-finalization
-(which re-initialize entropy) can succeed.
+[`update_fpmcu_firmware.py`] to reset `rollback_block_id` and entropy. So the
+follow-up re-finalization (which re-initialize entropy) can succeed.
## References
-* CrOS fingerprint factory requirements:
- [doc link](https://chromium.googlesource.com/chromiumos/platform/ec/+/HEAD/docs/fingerprint/fingerprint-factory-requirements.md)
+* CrOS fingerprint factory requirements: [doc link][factory requirements]
* The summary of CLs:
* Add a factory script to update FPMCU firmware:
[crrev/c/1918679](https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1918679),
@@ -95,3 +89,8 @@ to reset rollback\_block\_id and entropy. So the follow-up re-finalization
[crrev/c/1900503](https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1900503),
[crrev/c/1925927](https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1925927),
[crrev/c/1948163](https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1948163)
+
+[`update_fpmcu_firmware.py`]: https://crsrc.org/o/src/platform/factory/py/test/pytests/update_fpmcu_firmware.py;drc=672e24bb3e2dd0dec7578dcd4c52805d022662d1
+[factory requirements]: ./fingerprint-factory-requirements.md
+[`fingerprint_mcu.py`]: https://crsrc.org/o/src/platform/factory/py/test/pytests/fingerprint_mcu.py;drc=672e24bb3e2dd0dec7578dcd4c52805d022662d1
+[`flash_fp_mcu`]: https://crsrc.org/o/src/platform/ec/util/flash_fp_mcu;drc=12c473337e3bdcce6d180d266c9e9f8127448f33