summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJett Rink <jettrink@chromium.org>2020-02-07 10:42:41 -0700
committerCommit Bot <commit-bot@chromium.org>2020-02-11 01:45:42 +0000
commit1bc5961c7e2d4e7e623e69f628cb0069e02b6b4d (patch)
treecc73bc7469b4c1272372bbb97fd83f526d4fb526
parente18f1e42127a856ea6591e13ee6c26fe5781848d (diff)
downloadchrome-ec-1bc5961c7e2d4e7e623e69f628cb0069e02b6b4d.tar.gz
cleanup: add comments for MT flag use
Document why we need the MT flag as a compiler option BRANCH=none BUG=none TEST=builds Change-Id: Id6bceacc3b0af110f79d9f727ded595950fa2afb Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044358 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
-rw-r--r--Makefile.rules7
-rw-r--r--test/tpm_test/Makefile1
2 files changed, 8 insertions, 0 deletions
diff --git a/Makefile.rules b/Makefile.rules
index 915766051a..a8357a5b93 100644
--- a/Makefile.rules
+++ b/Makefile.rules
@@ -57,6 +57,11 @@ endif
# the resulting ec.bin
export STATIC_VERSION
+# Commonly used compiler options used in these scripts
+#
+# -MT explicitly sets target file name in generated .d files to work around
+# a ccache issue.
+
# commands to build all targets
cmd_libec = $(LD) -r $^ -o $@.1.o ${silent_err} && \
$(OBJCOPY) --localize-hidden $@.1.o $@.2.o ${silent_err} && \
@@ -599,6 +604,8 @@ $(out)/tags: $(out)/cscope.files
npx-monitor-dir:
$(Q)mkdir -p ${out}/chip/npcx/spiflashfw
+# See "Commonly used compiler options" for more documentation
+
# TODO: optional make rules for PROJECT_EXTRA
$(npcx-monitor-fw-bin):$(npcx-monitor-fw).c npx-monitor-dir
$(if $(V),,@echo ' EXTBIN ' $(subst $(out)/,,$@) ; )
diff --git a/test/tpm_test/Makefile b/test/tpm_test/Makefile
index e45f32ce0b..8942f0db1d 100644
--- a/test/tpm_test/Makefile
+++ b/test/tpm_test/Makefile
@@ -57,6 +57,7 @@ $(obj)/%.o: $(obj)/%.c
$(call echo," CC $(notdir $@)")
$(Q)gcc $(CFLAGS) -o $@ $<
+# See "Commonly used compiler options" for more documentation
$(obj)/%.o: %.c
$(call echo," CC $(notdir $@)")
$(Q)gcc $(CFLAGS) -Wall -Werror -MMD -MF $@.d -MT $@ -o $@ $<