summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTing Shen <phoenixshen@google.com>2022-07-05 16:59:00 +0800
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-08-30 04:22:47 +0000
commitc61d549588ea65c073e6ca05431af2b8b78068f4 (patch)
treefbc2cb30ba58f387cbd101b0ed3a6cffbcdd4b9f
parent730f220325d6729994a06e0eade3af238517cc4a (diff)
downloadchrome-ec-c61d549588ea65c073e6ca05431af2b8b78068f4.tar.gz
charger/rt9490: fix incorrect unit in ADC measurement
The units returned from charger is mV/mA, no need to multiply 1000. BUG=none TEST=manually checked datasheet BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: Icdb56294b6508f684a3d0eebeeadf786f5ef2086 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3744039 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org>
-rw-r--r--driver/charger/rt9490.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/driver/charger/rt9490.c b/driver/charger/rt9490.c
index 74b2f42ce3..c950150128 100644
--- a/driver/charger/rt9490.c
+++ b/driver/charger/rt9490.c
@@ -412,7 +412,7 @@ static enum ec_error_list rt9490_get_actual_current(int chgnum, int *current)
uint16_t reg_val;
RETURN_ERROR(rt9490_read16(chgnum, RT9490_REG_IBAT_ADC, &reg_val));
- *current = (int)reg_val * 1000;
+ *current = (int)reg_val;
return EC_SUCCESS;
}
@@ -421,7 +421,7 @@ static enum ec_error_list rt9490_get_actual_voltage(int chgnum, int *voltage)
uint16_t reg_val;
RETURN_ERROR(rt9490_read16(chgnum, RT9490_REG_VBAT_ADC, &reg_val));
- *voltage = (int)reg_val * 1000;
+ *voltage = (int)reg_val;
return EC_SUCCESS;
}
@@ -436,7 +436,7 @@ static enum ec_error_list rt9490_get_vbus_voltage(int chgnum, int port,
uint16_t reg_val;
RETURN_ERROR(rt9490_read16(chgnum, RT9490_REG_VBUS_ADC, &reg_val));
- *voltage = (int)reg_val * 1000;
+ *voltage = (int)reg_val;
return EC_SUCCESS;
}