diff options
| author | Li Feng <li1.feng@intel.com> | 2022-09-12 23:43:41 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-10-08 00:14:02 +0000 |
| commit | 976218ebde5629f229d71b66eaff19bfa95088c8 (patch) | |
| tree | 13f3ab84f169d37f6372b88426c3b49f3e1065b5 | |
| parent | 3a48b16f1c75debdcac39ab481c5e9e07ce46cfd (diff) | |
| download | chrome-ec-976218ebde5629f229d71b66eaff19bfa95088c8.tar.gz | |
ish: add HOSTCMD task check
host_packet_receive() is defined when HOSTCMD task is enabled; so add a
check of HOSTCMD; otherwise there is build error for board which doesn't
enable HOSTCMD task.
One of ISH solutions is to provide power management functionalities. It
powers on ISH and puts it in deep sleep. HOSTCMD task is disabled in this
case to avoid waking up ISH periodically.
BUG=b:234136500
BRANCH=none
TEST=build tglrvp_ish
Signed-off-by: Li Feng <li1.feng@intel.com>
Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
Change-Id: I64cd6ad4d292847d477f08708ece4d41b4e94650
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3892628
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | chip/ish/host_command_heci.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chip/ish/host_command_heci.c b/chip/ish/host_command_heci.c index ede615804c..3981ea5c53 100644 --- a/chip/ish/host_command_heci.c +++ b/chip/ish/host_command_heci.c @@ -119,7 +119,8 @@ static void cros_ec_ishtp_subsys_new_msg_received(const heci_handle_t handle, heci_packet.response_size = 0; heci_packet.driver_result = EC_RES_SUCCESS; - host_packet_receive(&heci_packet); + if (IS_ENABLED(HAS_TASK_HOSTCMD)) + host_packet_receive(&heci_packet); } /* |