summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaveh Jalali <caveh@chromium.org>2022-10-12 23:05:09 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-10-14 00:05:31 +0000
commit76c4c25e44e31ac73a487e04608e28bd85a8b488 (patch)
treefd8fadd3f99ec3eb803ac60e0b0617a2bcc26651
parentbfff80787a79ffabbc69b8e79f6a001e7f709e4f (diff)
downloadchrome-ec-76c4c25e44e31ac73a487e04608e28bd85a8b488.tar.gz
Makefile.toolchain: Do not use -Wimplicit-function-declaration for C++
Avoid errors like: cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ when compiling for target host (i.e. 'make hosttests'). As of gcc 9.2, implicit-function-declaration is only valid for regular C code compilation. cc1plus rejects this flag. BRANCH=none BUG=b:234181908 TEST='make buildall' no longer complains Change-Id: I8531c1e69a387f27d9a85be75e2e884f75950faa Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949585 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
-rw-r--r--Makefile.toolchain3
1 files changed, 2 insertions, 1 deletions
diff --git a/Makefile.toolchain b/Makefile.toolchain
index 8286be1e7c..3c93d774d4 100644
--- a/Makefile.toolchain
+++ b/Makefile.toolchain
@@ -112,7 +112,8 @@ HOSTGCOV=$(CURDIR)/util/llvm-gcov.sh
endif
C_WARN = -Wstrict-prototypes -Wdeclaration-after-statement -Wno-pointer-sign
-COMMON_WARN = -Wall -Wundef -Werror-implicit-function-declaration \
+C_WARN += -Werror-implicit-function-declaration
+COMMON_WARN = -Wall -Wundef \
-Wno-trigraphs -Wno-format-security -Wno-address-of-packed-member \
-fno-common -fno-strict-aliasing -fno-strict-overflow
# See https://www.chromium.org/chromium-os/build/c-exception-support