diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2022-10-20 14:02:30 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-10-21 00:15:40 +0000 |
| commit | 31a2f3ee725d1265e24aaff14b6d99eca8fe84c6 (patch) | |
| tree | 349316080c0ad02fce9a1b56ffcc3e3370dc8bd4 | |
| parent | bffa5b80693d1f322fe188fb36fe867cd9f4804e (diff) | |
| download | chrome-ec-31a2f3ee725d1265e24aaff14b6d99eca8fe84c6.tar.gz | |
TCPM: Remove unreachable code
Remove default: statement from pd_srccaps_dump. The switch statement
has cases for all 4 possible values of PDO Type, so the default case is
unreachable. Initialize pdo_type to satisfy the compiler.
BUG=b:236074634
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: I4d491663e3fbf648483df6af6d3c9ed8190dc79e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3968447
Reviewed-by: Diana Z <dzigterman@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| -rw-r--r-- | common/usb_common.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/common/usb_common.c b/common/usb_common.c index dec17cad6b..b4fefb6cf7 100644 --- a/common/usb_common.c +++ b/common/usb_common.c @@ -800,7 +800,7 @@ void pd_srccaps_dump(int port) #else const uint32_t pdo = srccaps[i]; const uint32_t pdo_mask = pdo & PDO_TYPE_MASK; - const char *pdo_type; + const char *pdo_type = "?"; bool range_flag = true; pd_extract_pdo_power(pdo, &max_ma, &max_mv, &min_mv); @@ -823,9 +823,6 @@ void pd_srccaps_dump(int port) range_flag = false; } break; - default: - pdo_type = "?"; - break; } ccprintf("Src %d: (%s) %dmV", i, pdo_type, max_mv); |