summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Massey <aaronmassey@google.com>2022-10-19 10:20:15 -0600
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-10-19 20:20:03 +0000
commite66c6fe6efab16bed9b06c1b9e349c71eddb5a3f (patch)
tree7a622085b5deb35c9579a1babacf04041d2a5b67
parentd57182c14a86ba260c3a2371d5cd25cf8e21eded (diff)
downloadchrome-ec-e66c6fe6efab16bed9b06c1b9e349c71eddb5a3f.tar.gz
battery_fuel_gauge: battery cutoff as static
The cut_off_battery_block_write() and cut_off_battery_sb_write() functions are only ever used in the same source they are defined in. Since these functions are only privately used, remove their header declarations and make them static. BRANCH=none BUG=none LOW_COVERAGE_REASON=Change of function signature TEST=zmake build -a TEST=make runhosttests -j TEST=CQ Signed-off-by: Aaron Massey <aaronmassey@google.com> Change-Id: Ic63c425870b338637a8e3996fa808842db85a18c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3966713 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-rw-r--r--common/battery_fuel_gauge.c16
-rw-r--r--include/battery_fuel_gauge.h16
2 files changed, 14 insertions, 18 deletions
diff --git a/common/battery_fuel_gauge.c b/common/battery_fuel_gauge.c
index 0382abca26..88f941f194 100644
--- a/common/battery_fuel_gauge.c
+++ b/common/battery_fuel_gauge.c
@@ -150,7 +150,13 @@ const struct battery_info *battery_get_info(void)
return &get_batt_params()->batt_info;
}
-int cut_off_battery_block_write(const struct ship_mode_info *ship_mode)
+/**
+ * Battery cut off command via SMBus write block.
+ *
+ * @param ship_mode Battery ship mode information
+ * @return non-zero if error
+ */
+static int cut_off_battery_block_write(const struct ship_mode_info *ship_mode)
{
int rv;
@@ -177,7 +183,13 @@ int cut_off_battery_block_write(const struct ship_mode_info *ship_mode)
return sb_write_block(ship_mode->reg_addr, cutdata, sizeof(cutdata));
}
-int cut_off_battery_sb_write(const struct ship_mode_info *ship_mode)
+/**
+ * Battery cut off command via SMBus write word.
+ *
+ * @param ship_mode Battery ship mode information
+ * @return non-zero if error
+ */
+static int cut_off_battery_sb_write(const struct ship_mode_info *ship_mode)
{
int rv;
diff --git a/include/battery_fuel_gauge.h b/include/battery_fuel_gauge.h
index b3fbb035e7..0a2a4064bb 100644
--- a/include/battery_fuel_gauge.h
+++ b/include/battery_fuel_gauge.h
@@ -103,22 +103,6 @@ __override_proto int board_get_default_battery_type(void);
int battery_is_charge_fet_disabled(void);
/**
- * Battery cut off command via SMBus write block.
- *
- * @param ship_mode Battery ship mode information
- * @return non-zero if error
- */
-int cut_off_battery_block_write(const struct ship_mode_info *ship_mode);
-
-/**
- * Battery cut off command via SMBus write word.
- *
- * @param ship_mode Battery ship mode information
- * @return non-zero if error
- */
-int cut_off_battery_sb_write(const struct ship_mode_info *ship_mode);
-
-/**
* Send the fuel gauge sleep command through SMBus.
*
* @return 0 if successful, non-zero if error occurred