diff options
| author | Boris Mittelberg <bmbm@google.com> | 2022-11-16 16:45:50 -0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-11-18 21:44:44 +0000 |
| commit | eccb0c71b575e461dd7b3c54af368bf95365a5de (patch) | |
| tree | bf40b8185b4e858f411191b5e5694b0bdc16e6ab | |
| parent | 8e66b54342f612c499ebb48a3038054bf40537e6 (diff) | |
| download | chrome-ec-eccb0c71b575e461dd7b3c54af368bf95365a5de.tar.gz | |
isl923x: fix index check
Fix chgnum bound check to avoid out-of-bound access
BUG=b:64477774
BRANCH=none
TEST=make -j buildall
Signed-off-by: Boris Mittelberg <bmbm@google.com>
Change-Id: I293732c2a751f71552b6cf17bc9c9e9e2df70391
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4032281
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
| -rw-r--r-- | driver/charger/isl923x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/driver/charger/isl923x.c b/driver/charger/isl923x.c index 2263c45b78..04db73353a 100644 --- a/driver/charger/isl923x.c +++ b/driver/charger/isl923x.c @@ -865,7 +865,7 @@ enum ec_error_list raa489000_is_acok(int chgnum, bool *acok) { int regval, rv; - if ((chgnum < 0) || (chgnum > board_get_charger_chip_count())) { + if ((chgnum < 0) || (chgnum >= board_get_charger_chip_count())) { CPRINTS("%s: Invalid chgnum! (%d)", __func__, chgnum); return EC_ERROR_INVAL; } @@ -890,7 +890,7 @@ void raa489000_hibernate(int chgnum, bool disable_adc) { int rv, regval; - if ((chgnum < 0) || (chgnum > board_get_charger_chip_count())) { + if ((chgnum < 0) || (chgnum >= board_get_charger_chip_count())) { CPRINTS("%s: Invalid chgnum! (%d)", __func__, chgnum); return; } |