diff options
| author | Caveh Jalali <caveh@chromium.org> | 2023-01-12 22:40:18 -0800 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-01-18 01:21:00 +0000 |
| commit | 4e444720f5c3dedeef7c56d93233dc1254736151 (patch) | |
| tree | bb69ca1e716d03f872f348b302a2a92afc710791 | |
| parent | 026ebd2b284bbe9915e122a8e30a06bb84835094 (diff) | |
| download | chrome-ec-4e444720f5c3dedeef7c56d93233dc1254736151.tar.gz | |
common/usb_pd_host_cmd: Fix EC_CMD_USB_PD_DISCOVERY param
The EC_CMD_USB_PD_DISCOVERY host command should be implemented to use a
'struct ec_params_usb_pd_info' as the input parameter instead of a
uint8_t. Callers (ectool, unit tests, kernel) already pass a 'struct
ec_params_usb_pd_info' for this host command, so it makes sense to "fix"
the implementation. The struct only has a uint8_t member, so no
functional change is introduced.
BRANCH=none
BUG=b:258110734
TEST='./twister -v -T zephyr/test' passes
'make buildall' passes
Change-Id: If6ce382d3ccdbe069d69b02fad6976a7ba09c377
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4171494
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usb_pd_host_cmd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/common/usb_pd_host_cmd.c b/common/usb_pd_host_cmd.c index ea05de3457..020c332d7a 100644 --- a/common/usb_pd_host_cmd.c +++ b/common/usb_pd_host_cmd.c @@ -136,18 +136,18 @@ DECLARE_HOST_COMMAND(EC_CMD_USB_PD_SET_AMODE, hc_remote_pd_set_amode, static enum ec_status hc_remote_pd_discovery(struct host_cmd_handler_args *args) { - const uint8_t *port = args->params; + const struct ec_params_usb_pd_info_request *p = args->params; struct ec_params_usb_pd_discovery_entry *r = args->response; - if (*port >= board_get_usb_pd_port_count()) + if (p->port >= board_get_usb_pd_port_count()) return EC_RES_INVALID_PARAM; - r->vid = pd_get_identity_vid(*port); - r->ptype = pd_get_product_type(*port); + r->vid = pd_get_identity_vid(p->port); + r->ptype = pd_get_product_type(p->port); /* pid only included if vid is assigned */ if (r->vid) - r->pid = pd_get_identity_pid(*port); + r->pid = pd_get_identity_pid(p->port); args->response_size = sizeof(*r); return EC_RES_SUCCESS; |