diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2023-02-17 13:46:20 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-02-21 18:03:35 +0000 |
| commit | e3c57eec7e9ca7c20a985e0f75caf9b4ec45b40e (patch) | |
| tree | 7b5cca3f34dc386ea0abc0e3bbfebeb37c0c4874 | |
| parent | b35e33ada5e49c782c086d176bead8f28aafabfd (diff) | |
| download | chrome-ec-e3c57eec7e9ca7c20a985e0f75caf9b4ec45b40e.tar.gz | |
TCPMv2: Remove pd_dev_dump_info
Remove the remnants of CMD_PD_DEV_DUMP_INFO from TCPMv2. The function
that was left did not link when enabled.
BUG=b:250015035
TEST=make buildall
BRANCH=none
Change-Id: I884bade638873d79dfcbc72bb5bf98d53f5afa78
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4263563
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 3 | ||||
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 13 | ||||
| -rw-r--r-- | docs/reducing_ec_image_size.md | 2 |
3 files changed, 1 insertions, 17 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 3037ed1fca..7824a285d5 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -2038,9 +2038,6 @@ int pd_dev_store_rw_hash(int port, uint16_t dev_id, uint32_t *rw_hash, { pe[port].dev_id = dev_id; memcpy(pe[port].dev_rw_hash, rw_hash, PD_RW_HASH_SIZE); -#ifdef CONFIG_CMD_PD_DEV_DUMP_INFO - pd_dev_dump_info(dev_id, rw_hash); -#endif pe[port].current_image = current_image; if (IS_ENABLED(CONFIG_USB_PD_HOST_CMD)) { diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 962b65154a..6690fff25b 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -801,19 +801,6 @@ enum pd_dual_role_states pd_get_dual_role(int port) return drp_state[port]; } -#ifdef CONFIG_CMD_PD_DEV_DUMP_INFO -static inline void pd_dev_dump_info(uint16_t dev_id, uint32_t *hash) -{ - int j; - - ccprintf("DevId:%d.%d Hash:", HW_DEV_ID_MAJ(dev_id), - HW_DEV_ID_MIN(dev_id)); - for (j = 0; j < PD_RW_HASH_SIZE / 4; j++) - ccprintf(" %08x ", hash[j]); - ccprintf("\n"); -} -#endif /* CONFIG_CMD_PD_DEV_DUMP_INFO */ - const char *tc_get_current_state(int port) { if (IS_ENABLED(USB_PD_DEBUG_LABELS)) diff --git a/docs/reducing_ec_image_size.md b/docs/reducing_ec_image_size.md index 58ed66e25c..d58827441a 100644 --- a/docs/reducing_ec_image_size.md +++ b/docs/reducing_ec_image_size.md @@ -216,7 +216,7 @@ prj.conf file to disable the console command. | | CONFIG_CMD_MFALLOW | `mfallow` | | | | CONFIG_CMD_MMAPINFO | `mmapinfo` | | | x | CONFIG_CMD_PD | `pd` | Used by FAFT PD, TAST `firmware.ECSystemLocked` | -| | CONFIG_CMD_PD_DEV_DUMP_INFO | | Not a console command | +| | CONFIG_CMD_PD_DEV_DUMP_INFO | | Not supported by TCPMv2 | | | CONFIG_CMD_PD_FLASH | `pd flash` | Not supported by TCPMv2 | | | CONFIG_CMD_PD_SRCCAPS_REDUCED_SIZE | `pd <port> srccaps` | Defining this reduces the verbosity of this command, saving bytes | | | CONFIG_CMD_PECI | `peci` | firmware_ECThermal uses `ectool tempsinfo` | |