Herobrine: change GPIO backlight to open drain

change backlight GPIO to open drain so it correctly turns off when
closing the lid.

BUG=b:268536485
TEST=1: change host command to always set backlight to 100% no matter
        what the actual parameter passed is,
	result: backlight is always on.
     2: implement the changes in this CL,
        result: backlight is off when laptop closes demonstrating EC
	turn off supercedes AP command.
     tested on villager.
BRANCH=none

Change-Id: Icb2694cb8aaf0371130d934e1234dd6c8f146eaf
Signed-off-by: Jason Yuan <jasonyuan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4307976
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Tested-by: zhi cheng yuan <jasonyuan@chromium.org>
Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@google.com>

5 files changed, 25 insertions, 20 deletions

diff --git a/zephyr/program/herobrine/evoker/gpio.dtsi b/zephyr/program/herobrine/evoker/gpio.dtsi
index e16191f247..0103f7cb6b 100644
--- a/zephyr/program/herobrine/evoker/gpio.dtsi
+++ b/zephyr/program/herobrine/evoker/gpio.dtsi
@@ -128,11 +128,12 @@
 		};
 		ec_bl_disable_l {
 			/* The PMIC controls backlight enable and this pin must
-			 * be HiZ for normal operation. But the backlight can
-			 * be enabled by setting this pin low and configuring it
-			 * as an output.
+			 * be HiZ for normal operation. The EC is allowed to
+			 * drive low to abruptly removes power from the eDP
+			 * panel in cases like lid close. So the signal is open
+			 * drain (allowed to drive low, never drive high).
 			 */
-			gpios = <&gpiob 6 GPIO_INPUT>;
+			gpios = <&gpiob 6 GPIO_ODR_HIGH>;
 			enum-name = "GPIO_ENABLE_BACKLIGHT";
 		};
 		lid_accel_int_l {
diff --git a/zephyr/program/herobrine/gpio.dtsi b/zephyr/program/herobrine/gpio.dtsi
index 7245c3466f..9c982f0ef9 100644
--- a/zephyr/program/herobrine/gpio.dtsi
+++ b/zephyr/program/herobrine/gpio.dtsi
@@ -131,11 +131,12 @@
 		};
 		ec_bl_disable_l {
 			/* The PMIC controls backlight enable and this pin must
-			 * be HiZ for normal operation. But the backlight can
-			 * be enabled by setting this pin low and configuring it
-			 * as an output.
+			 * be HiZ for normal operation. The EC is allowed to
+			 * drive low to abruptly removes power from the eDP
+			 * panel in cases like lid close. So the signal is open
+			 * drain (allowed to drive low, never drive high).
 			 */
-			gpios = <&gpiob 6 GPIO_INPUT>;
+			gpios = <&gpiob 6 GPIO_ODR_HIGH>;
 			enum-name = "GPIO_ENABLE_BACKLIGHT";
 		};
 		lid_accel_int_l {
diff --git a/zephyr/program/herobrine/hoglin/gpio.dtsi b/zephyr/program/herobrine/hoglin/gpio.dtsi
index 43162b3de9..72f5fb510d 100644
--- a/zephyr/program/herobrine/hoglin/gpio.dtsi
+++ b/zephyr/program/herobrine/hoglin/gpio.dtsi
@@ -131,11 +131,12 @@
 		};
 		ec_bl_disable_l {
 			/* The PMIC controls backlight enable and this pin must
-			 * be HiZ for normal operation. But the backlight can
-			 * be enabled by setting this pin low and configuring it
-			 * as an output.
+			 * be HiZ for normal operation. The EC is allowed to
+			 * drive low to abruptly removes power from the eDP
+			 * panel in cases like lid close. So the signal is open
+			 * drain (allowed to drive low, never drive high).
 			 */
-			gpios = <&gpiob 6 GPIO_INPUT>;
+			gpios = <&gpiob 6 GPIO_ODR_HIGH>;
 			enum-name = "GPIO_ENABLE_BACKLIGHT";
 		};
 		lid_accel_int_l {
diff --git a/zephyr/program/herobrine/villager/gpio.dtsi b/zephyr/program/herobrine/villager/gpio.dtsi
index b947e5acd6..9c94926579 100644
--- a/zephyr/program/herobrine/villager/gpio.dtsi
+++ b/zephyr/program/herobrine/villager/gpio.dtsi
@@ -131,11 +131,12 @@
 		};
 		ec_bl_disable_l {
 			/* The PMIC controls backlight enable and this pin must
-			 * be HiZ for normal operation. But the backlight can
-			 * be enabled by setting this pin low and configuring it
-			 * as an output.
+			 * be HiZ for normal operation. The EC is allowed to
+			 * drive low to abruptly removes power from the eDP
+			 * panel in cases like lid close. So the signal is open
+			 * drain (allowed to drive low, never drive high).
 			 */
-			gpios = <&gpiob 6 GPIO_INPUT>;
+			gpios = <&gpiob 6 GPIO_ODR_HIGH>;
 			enum-name = "GPIO_ENABLE_BACKLIGHT";
 		};
 		lid_accel_int_l {
diff --git a/zephyr/program/herobrine/zombie/gpio.dtsi b/zephyr/program/herobrine/zombie/gpio.dtsi
index c554a079d8..6f0e0ed501 100644
--- a/zephyr/program/herobrine/zombie/gpio.dtsi
+++ b/zephyr/program/herobrine/zombie/gpio.dtsi
@@ -131,11 +131,12 @@
 		};
 		ec_bl_disable_l {
 			/* The PMIC controls backlight enable and this pin must
-			 * be HiZ for normal operation. But the backlight can
-			 * be enabled by setting this pin low and configuring it
-			 * as an output.
+			 * be HiZ for normal operation. The EC is allowed to
+			 * drive low to abruptly removes power from the eDP
+			 * panel in cases like lid close. So the signal is open
+			 * drain (allowed to drive low, never drive high).
 			 */
-			gpios = <&gpiob 6 GPIO_INPUT>;
+			gpios = <&gpiob 6 GPIO_ODR_HIGH>;
 			enum-name = "GPIO_ENABLE_BACKLIGHT";
 		};
 		lid_accel_int_l {