diff options
| author | Diana Z <dzigterman@chromium.org> | 2023-04-04 15:47:06 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-04-06 21:34:09 +0000 |
| commit | 67d4a05823bcf880117611942bcd0025274c1ed5 (patch) | |
| tree | e58a4217daed31e03ffa8d7e92de921b23c04279 | |
| parent | c84b3136cebf96c919b817dddb48d8e0de943dc5 (diff) | |
| download | chrome-ec-67d4a05823bcf880117611942bcd0025274c1ed5.tar.gz | |
NX20P348X: Correct dead battery exit error handling
Currently, when we hit the maximum number of dead battery exit errors
the driver will read/modify/write to mask off the interrupt. However,
it will only modify/write if the read fails. Trigger instead on the
read being successful.
BRANCH=None
BUG=None
TEST=./twister -T ./zephyr/test
Change-Id: I44404c79abb6be04abc25ff35ecbe9bcdf523308
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4404282
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | driver/ppc/nx20p348x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/ppc/nx20p348x.c b/driver/ppc/nx20p348x.c index 21f49e0983..b11dee30f4 100644 --- a/driver/ppc/nx20p348x.c +++ b/driver/ppc/nx20p348x.c @@ -410,7 +410,7 @@ static void nx20p348x_handle_interrupt(int port) NX20P348X_DB_EXIT_FAIL_THRESHOLD) { ppc_prints("failed to exit DB mode", port); if (read_reg(port, NX20P348X_INTERRUPT1_MASK_REG, - &mask_reg)) { + &mask_reg) == 0) { mask_reg |= NX20P348X_INT1_DBEXIT_ERR; write_reg(port, NX20P348X_INTERRUPT1_MASK_REG, mask_reg); |