diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2023-04-19 11:01:58 +1000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-04-19 14:10:14 +0000 |
| commit | 296a16ab4d9b80168b1a09f63c27b12a13c03180 (patch) | |
| tree | d884ebcb72493e45481353c276dd2b79de2595d2 | |
| parent | fd2415cda6a261b92390aad04829f46f33ffc9e6 (diff) | |
| download | chrome-ec-296a16ab4d9b80168b1a09f63c27b12a13c03180.tar.gz | |
zephyr: make console buffer logging depend on non-minimal logging
The console buffer log backend depends on CONFIG_LOG_OUTPUT, which only
does something if logging is enabled and not in minimal mode. Without
this dependency, enabling this backend while in minimal mode causes a
link-time error because symbols enabled by CONFIG_LOG_OUTPUT are absent.
When in minimal mode log backends are ignored completely anyway, so this
change also helps prevent accidental misconfiguration because it doesn't
make sense to enable a log backend that will never be used.
BUG=b:265781350
TEST=zmake build -a
BRANCH=none
Change-Id: Ib0722102963b44484f07a779b2bbbde72b29b743
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4445346
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org>
| -rw-r--r-- | zephyr/Kconfig.console | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/zephyr/Kconfig.console b/zephyr/Kconfig.console index 78a2233246..030217a87f 100644 --- a/zephyr/Kconfig.console +++ b/zephyr/Kconfig.console @@ -82,6 +82,7 @@ menuconfig PLATFORM_EC_CONSOLE_DEBUG config PLATFORM_EC_LOG_BACKEND_CONSOLE_BUFFER bool "Logging backend for the console buffer" depends on PLATFORM_EC_HOSTCMD_CONSOLE + depends on !LOG_MODE_MINIMAL select LOG_OUTPUT help Enable the logging backend for the console buffer. |