diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2023-04-27 13:15:53 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-04-29 01:19:17 +0000 |
| commit | b804b9d4d8d3cd06c10c1e34e1f2a19e6463bb62 (patch) | |
| tree | 6b66bbb55b5730ae105e4c4b3b818c009954a54e | |
| parent | bb9faa8c2dcf6d0bc9bf160261d5eb797065af9e (diff) | |
| download | chrome-ec-b804b9d4d8d3cd06c10c1e34e1f2a19e6463bb62.tar.gz | |
common/fpsensor: Add TODOs
BRANCH=none
BUG=b:276344630, b:279950931
TEST=none
Change-Id: If869ff19cd01b2bd3e5fd6406fd77856b289e704
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4484334
Reviewed-by: Yi Chou <yich@google.com>
| -rw-r--r-- | common/fpsensor/fpsensor_crypto.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/common/fpsensor/fpsensor_crypto.cc b/common/fpsensor/fpsensor_crypto.cc index 774090ca20..7d950b8974 100644 --- a/common/fpsensor/fpsensor_crypto.cc +++ b/common/fpsensor/fpsensor_crypto.cc @@ -221,6 +221,7 @@ int derive_encryption_key(uint8_t *out_key, const uint8_t *salt) return ret; } + /* TODO (b/276344630): Replace with boringssl version. */ /* "Extract step of HKDF. */ hkdf_extract(prk, salt, FP_CONTEXT_ENCRYPTION_SALT_BYTES, ikm, sizeof(ikm)); @@ -251,6 +252,7 @@ int aes_gcm_encrypt(const uint8_t *key, int key_size, const uint8_t *plaintext, return EC_ERROR_INVAL; } + /* TODO(b/279950931): Use public boringssl API. */ res = AES_set_encrypt_key(key, 8 * key_size, &aes_key); if (res) { CPRINTS("Failed to set encryption key: %d", res); @@ -283,6 +285,7 @@ int aes_gcm_decrypt(const uint8_t *key, int key_size, uint8_t *plaintext, return EC_ERROR_INVAL; } + /* TODO(b/279950931): Use public boringssl API. */ res = AES_set_encrypt_key(key, 8 * key_size, &aes_key); if (res) { CPRINTS("Failed to set decryption key: %d", res); |