diff options
| author | Andrew Bresticker <abrestic@chromium.org> | 2013-08-22 14:21:29 -0700 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-08-24 09:37:48 -0700 |
| commit | 62e9444161bba05da2dd219214be01084312d2fb (patch) | |
| tree | d9a92ae294d877811d7ab20115f469097cb64113 | |
| parent | 2271ee8c7c57a222fd1c95526f9d9b6189bd43d5 (diff) | |
| download | chrome-ec-62e9444161bba05da2dd219214be01084312d2fb.tar.gz | |
pit: Disable CONFIG_HOST_COMMAND_STATUS
With CONFIG_HOST_COMMAND_STATUS, the EC can respond to a command
with EC_RES_IN_PROGRESS, indicating to the AP that it should poll
for completion of the command with EC_CMD_GET_COMMS_STATUS. The
kernel, however, only guarantees the atomicity of single commands.
As a result, i2c passtrough or keyboard commands could be issued
while the AP is polling for completion of a flashrom command. By
disabling CONFIG_HOST_COMMAND_STATUS, we eliminate polling of the
EC status by the AP so that there is no interleaving of commands.
BUG=chrome-os-partner:20978
TEST=flashrom on Pit
BRANCH=pit
Original-Change-Id: I48b29a0dbbcc56fc55f72ca64b8aff51036740e3
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66703
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit 2db4fcfb267b938fcc35af2a0d2e374f99551743)
Change-Id: Iac7c15ec337d618cd6d95439d4b922bf3ec43916
Reviewed-on: https://gerrit.chromium.org/gerrit/66828
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: Andrew Bresticker <abrestic@chromium.org>
Commit-Queue: Andrew Bresticker <abrestic@chromium.org>
| -rw-r--r-- | board/pit/board.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/board/pit/board.h b/board/pit/board.h index 9f700a48dc..c9f4e5d51e 100644 --- a/board/pit/board.h +++ b/board/pit/board.h @@ -15,7 +15,6 @@ #define CONFIG_CHIPSET_GAIA #define CONFIG_CMD_PMU #define CONFIG_EXTPOWER_GPIO -#define CONFIG_HOST_COMMAND_STATUS #define CONFIG_I2C #define CONFIG_KEYBOARD_PROTOCOL_MKBP #define CONFIG_PMU_HARD_RESET |