diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-21 12:49:19 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-22 01:11:57 +0000 |
| commit | 8e13fec4b85a1637ac1ca2bbde90a248f1ef1d67 (patch) | |
| tree | a043aa5e24ccc2c25c7308088ac68fddc3b66418 | |
| parent | 10bd1db6d73e21619e789d73c8233dea2c493510 (diff) | |
| download | chrome-ec-8e13fec4b85a1637ac1ca2bbde90a248f1ef1d67.tar.gz | |
cleanup: Comments in extpower_falco.c
Note that adapter current limits are specific to the given battery
charger chip used in falco. Since the file is named extpower_falco.c,
no additional fixing needed.
Comment change only; code is the same.
BUG=none
BRANCH=none
TEST=compile falco
Change-Id: I28d8b6c9335ec188c30f7c47fb2f8ecdda276bae
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/173914
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
| -rw-r--r-- | common/extpower_falco.c | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/common/extpower_falco.c b/common/extpower_falco.c index e1db0fecb7..abcfadfa14 100644 --- a/common/extpower_falco.c +++ b/common/extpower_falco.c @@ -54,13 +54,19 @@ BUILD_ASSERT(ARRAY_SIZE(ad_id_vals) == NUM_ADAPTER_TYPES); test_export_static int ad_input_current[][NUM_AC_TURBO_STATES] = { - /* Current limits in mA, for turbo off and turbo on. In hex, - * because the BQ24738 Input Current Register masks off bits 6-0. - * FIXME: That constraint may vary with other chargers. */ - {0x0a00, 0x0a00}, /* ADAPTER_UNKNOWN */ - {0x0600, 0x0800}, /* ADAPTER_45W */ - {0x0a00, 0x0c00}, /* ADAPTER_65W */ - {0x0f00, 0x1100} /* ADAPTER_90W */ + /* + * Current limits in mA for each adapter, for turbo off and turbo on. + * Values are in hex to avoid roundoff, because the BQ24738 Input + * Current Register masks off bits 6-0. + * + * Note that this is very specific to the combinations of adapters and + * BQ24738 charger chip on Falco. + */ + + {0x0a00, 0x0a00}, /* ADAPTER_UNKNOWN ~ 2.5 A */ + {0x0600, 0x0800}, /* ADAPTER_45W ~ 1.5-2.0 A */ + {0x0a00, 0x0c00}, /* ADAPTER_65W ~ 2.5-3.0 A */ + {0x0f00, 0x1100} /* ADAPTER_90W ~ 3.8-4.3 A */ }; BUILD_ASSERT(ARRAY_SIZE(ad_input_current) == NUM_ADAPTER_TYPES); |