diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-23 14:28:01 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-25 01:33:10 +0000 |
| commit | c8bcc57aac120ed78337e4bfa2efb9e6b4792684 (patch) | |
| tree | aafc309df70073d205184ab6c5212c563b5f2231 | |
| parent | 5e19f9c5d529bde4377842fc27d4d86e0b83dcf1 (diff) | |
| download | chrome-ec-c8bcc57aac120ed78337e4bfa2efb9e6b4792684.tar.gz | |
cleanup: Re-enable keyboard console channel for ARM boards
Originally, the ARM boards printed the keyboard scan matrix whenever
it changed. This generated a lot of output, so we filtered that at
the console channel level. When we refactored the keyboard scan
module, that changed so that the scan matrix was not printed by
default, and the 'ksstate' debug command was used to enable printing
it. But on ARM boards, 'ksstate on' wouldn't do anything without ALSO
using 'chan -1' to turn the keyboard console channel back on. And
without the scan matrix printing by default, there's no reason to keep
the keyboard channel off by default.
BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all boards
bang on keyboard on pit and don't see much debug output
ksstate on
now bang on keyboard and see matrix changes
Change-Id: I554b42e7582d507530cdecad7b35df71ca0e634f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174373
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
| -rw-r--r-- | board/daisy/board.h | 3 | ||||
| -rw-r--r-- | board/discovery/board.h | 3 | ||||
| -rw-r--r-- | board/kirby/board.h | 3 | ||||
| -rw-r--r-- | board/mccroskey/board.h | 3 | ||||
| -rw-r--r-- | board/nyan/board.h | 3 | ||||
| -rw-r--r-- | board/pit/board.h | 3 | ||||
| -rw-r--r-- | board/puppy/board.h | 3 | ||||
| -rw-r--r-- | board/snow/board.h | 3 | ||||
| -rw-r--r-- | board/spring/board.h | 3 |
9 files changed, 0 insertions, 27 deletions
diff --git a/board/daisy/board.h b/board/daisy/board.h index 92f998aa5e..0dee1cd121 100644 --- a/board/daisy/board.h +++ b/board/daisy/board.h @@ -40,9 +40,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_B, GPIO_C diff --git a/board/discovery/board.h b/board/discovery/board.h index 541568dd00..c884026975 100644 --- a/board/discovery/board.h +++ b/board/discovery/board.h @@ -26,9 +26,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Timer selection */ #define TIM_CLOCK_MSB 3 #define TIM_CLOCK_LSB 4 diff --git a/board/kirby/board.h b/board/kirby/board.h index 592bc8d856..17ec881f7c 100644 --- a/board/kirby/board.h +++ b/board/kirby/board.h @@ -40,9 +40,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_D diff --git a/board/mccroskey/board.h b/board/mccroskey/board.h index 9d8ea06eab..376037147e 100644 --- a/board/mccroskey/board.h +++ b/board/mccroskey/board.h @@ -38,9 +38,6 @@ enum module_id { MODULE_UART, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL) - /* Keyboard output ports */ #define KB_OUT_PORT_LIST GPIO_C diff --git a/board/nyan/board.h b/board/nyan/board.h index c43c664943..47752d9c2f 100644 --- a/board/nyan/board.h +++ b/board/nyan/board.h @@ -32,9 +32,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C diff --git a/board/pit/board.h b/board/pit/board.h index 2f95545e90..2763979567 100644 --- a/board/pit/board.h +++ b/board/pit/board.h @@ -37,9 +37,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C diff --git a/board/puppy/board.h b/board/puppy/board.h index 79a993dd54..66f0cc1ae5 100644 --- a/board/puppy/board.h +++ b/board/puppy/board.h @@ -35,9 +35,6 @@ enum module_id { MODULE_CHIPSET, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_A, GPIO_B, GPIO_C diff --git a/board/snow/board.h b/board/snow/board.h index 0a29e18a3b..f0e1ed7b24 100644 --- a/board/snow/board.h +++ b/board/snow/board.h @@ -44,9 +44,6 @@ enum module_id { MODULE_UART, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output ports */ #define KB_OUT_PORT_LIST GPIO_B, GPIO_C diff --git a/board/spring/board.h b/board/spring/board.h index f2c27605b2..ef8e14f328 100644 --- a/board/spring/board.h +++ b/board/spring/board.h @@ -45,9 +45,6 @@ enum module_id { MODULE_EXTPOWER_USB, }; -/* By default, enable all console messages except keyboard */ -#define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_KEYSCAN)) - /* Keyboard output port list */ #define KB_OUT_PORT_LIST GPIO_B, GPIO_C |