diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-09-23 15:38:24 +0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-09-24 06:25:33 +0000 |
| commit | cf62055270fa35fb613db3a850c81e6a9bc01af0 (patch) | |
| tree | 4e4b762f45f4bc76f423314a1f82341da4845685 | |
| parent | 4afee85638257d71600e8ad8c74f0a2d7b35ad0c (diff) | |
| download | chrome-ec-cf62055270fa35fb613db3a850c81e6a9bc01af0.tar.gz | |
Add options to disable rarely used console commands
'powerindebug' is only used when there is a problem with power
sequencing. 'taskready' is rarely used and the same info can be
retrieved by 'taskinfo'.
Put both behind config flags and disable 'taskready' by default. Also
disable 'powerindebug' for Ryu.
BUG=chrome-os-partner:32203
TEST=Build Ryu and check flash space used.
BRANCH=None
Change-Id: I753a1f5411d6e840a80aba03afc94f9640d381a8
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/219490
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/ryu/board.h | 3 | ||||
| -rw-r--r-- | core/cortex-m/task.c | 2 | ||||
| -rw-r--r-- | core/cortex-m0/task.c | 2 | ||||
| -rw-r--r-- | include/config.h | 2 | ||||
| -rw-r--r-- | power/common.c | 2 |
5 files changed, 11 insertions, 0 deletions
diff --git a/board/ryu/board.h b/board/ryu/board.h index a00a1b6897..04bf5e4d94 100644 --- a/board/ryu/board.h +++ b/board/ryu/board.h @@ -37,6 +37,9 @@ #define CONFIG_INDUCTIVE_CHARGING #undef CONFIG_HIBERNATE +/* Disable unused console command to save flash space */ +#undef CONFIG_CMD_POWERINDEBUG + /* * Pericom I2C workaround * TODO(crosbug.com/p/31529): Remove this. diff --git a/core/cortex-m/task.c b/core/cortex-m/task.c index e031d58c04..de690ad007 100644 --- a/core/cortex-m/task.c +++ b/core/cortex-m/task.c @@ -567,6 +567,7 @@ DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, "Print task info", NULL); +#ifdef CONFIG_CMD_TASKREADY static int command_task_ready(int argc, char **argv) { if (argc < 2) { @@ -583,6 +584,7 @@ DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", "Print/set ready tasks", NULL); +#endif #ifdef CONFIG_CMD_STACKOVERFLOW static void stack_overflow_recurse(int n) diff --git a/core/cortex-m0/task.c b/core/cortex-m0/task.c index 830d6a520c..59a8e4d7d6 100644 --- a/core/cortex-m0/task.c +++ b/core/cortex-m0/task.c @@ -538,6 +538,7 @@ DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, "Print task info", NULL); +#ifdef CONFIG_CMD_TASKREADY static int command_task_ready(int argc, char **argv) { if (argc < 2) { @@ -554,6 +555,7 @@ DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", "Print/set ready tasks", NULL); +#endif #ifdef CONFIG_CMD_STACKOVERFLOW static void stack_overflow_recurse(int n) diff --git a/include/config.h b/include/config.h index ffd95fe0f2..3f6598b50e 100644 --- a/include/config.h +++ b/include/config.h @@ -323,12 +323,14 @@ #define CONFIG_CMD_LID_ANGLE #undef CONFIG_CMD_PLL #undef CONFIG_CMD_PMU +#define CONFIG_CMD_POWERINDEBUG #undef CONFIG_CMD_POWERLED #undef CONFIG_CMD_RTC_ALARM #undef CONFIG_CMD_SCRATCHPAD #undef CONFIG_CMD_SLEEP #undef CONFIG_CMD_SPI_FLASH #undef CONFIG_CMD_STACKOVERFLOW +#undef CONFIG_CMD_TASKREADY /*****************************************************************************/ diff --git a/power/common.c b/power/common.c index d4063d8db3..96c6966900 100644 --- a/power/common.c +++ b/power/common.c @@ -432,6 +432,7 @@ DECLARE_CONSOLE_COMMAND(powerinfo, command_powerinfo, "Show current power state", NULL); +#ifdef CONFIG_CMD_POWERINDEBUG static int command_powerindebug(int argc, char **argv) { const struct power_signal_info *s = power_signal_list; @@ -466,6 +467,7 @@ DECLARE_CONSOLE_COMMAND(powerindebug, command_powerindebug, "[mask]", "Get/set power input debug mask", NULL); +#endif #ifdef CONFIG_HIBERNATE static int command_hibernation_delay(int argc, char **argv) |