diff options
| author | Todd Broch <tbroch@chromium.org> | 2014-10-28 15:04:37 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-10-30 21:48:22 +0000 |
| commit | 1e7d66eabc26879d6e5c934b368fe08795939d34 (patch) | |
| tree | 2cf13f579a6457922b8992db8b1e5aa07cfb8c15 | |
| parent | a3913d99d7a40062144b96d505bba56a62986faa (diff) | |
| download | chrome-ec-1e7d66eabc26879d6e5c934b368fe08795939d34.tar.gz | |
pd: dingdong/hoho: assert USB billboard only in AMA VDO.
BRANCH=samus
BUG=chrome-os-partner:31192,chrome-os-partner:31193
TEST=manual
Attach hoho/dingdong to samus and see AMA VDO bits <2:0> set to 0x3
during the discover identity response.
AMA VDO
|------|
SVDM/4 [1] ff008041 340018d1 00000000 1100000b
Change-Id: I1e2459b87cceca88ab3ae09440b689041ae03c7c
Signed-off-by: Todd Broch <tbroch@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/226101
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/dingdong/usb_pd_policy.c | 2 | ||||
| -rw-r--r-- | board/hoho/usb_pd_policy.c | 2 | ||||
| -rw-r--r-- | include/usb_pd.h | 2 |
3 files changed, 4 insertions, 2 deletions
diff --git a/board/dingdong/usb_pd_policy.c b/board/dingdong/usb_pd_policy.c index 10b5ab48e1..2e18792733 100644 --- a/board/dingdong/usb_pd_policy.c +++ b/board/dingdong/usb_pd_policy.c @@ -110,7 +110,7 @@ const uint32_t vdo_ama = VDO_AMA(CONFIG_USB_PD_IDENTITY_HW_VERS, 0, /* Vconn power */ 0, /* Vconn power required */ 1, /* Vbus power required */ - 0 /* USB SS support */); + AMA_USBSS_BBONLY /* USB SS support */); static int svdm_response_identity(int port, uint32_t *payload) { diff --git a/board/hoho/usb_pd_policy.c b/board/hoho/usb_pd_policy.c index f52416b19d..4eff69b49e 100644 --- a/board/hoho/usb_pd_policy.c +++ b/board/hoho/usb_pd_policy.c @@ -110,7 +110,7 @@ const uint32_t vdo_ama = VDO_AMA(CONFIG_USB_PD_IDENTITY_HW_VERS, 0, /* Vconn power */ 0, /* Vconn power required */ 1, /* Vbus power required */ - 0 /* USB SS support */); + AMA_USBSS_BBONLY /* USB SS support */); static int svdm_response_identity(int port, uint32_t *payload) { diff --git a/include/usb_pd.h b/include/usb_pd.h index 8f231a754f..c13e5e9588 100644 --- a/include/usb_pd.h +++ b/include/usb_pd.h @@ -345,6 +345,8 @@ struct pd_policy { #define PD_VDO_AMA_VCONN_REQ(vdo) (((vdo) >> 4) & 1) #define PD_VDO_AMA_VBUS_REQ(vdo) (((vdo) >> 3) & 1) +#define AMA_USBSS_BBONLY 0x3 + /* * SVDM Discover SVIDs request -> response * |