diff options
| author | Todd Broch <tbroch@chromium.org> | 2014-11-25 08:20:59 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-12-16 22:47:57 +0000 |
| commit | e19f0927be9fc339456e1c589fd41c4f033d135b (patch) | |
| tree | 8367a15ef734f70db1b73ba2e833296fd9b72f5a | |
| parent | 07203ac931d5cbe79ad33f1ec9193678c8c540bd (diff) | |
| download | chrome-ec-e19f0927be9fc339456e1c589fd41c4f033d135b.tar.gz | |
hoho/dingdong: Add GPIOs for factory test points.
Use GPIOs A2 (STM_READY) & A7 (MCDP_READY, hoho only) to signal test
fixture of these devices readiness.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=samus
BUG=chrome-os-partner:34122
TEST=manual, compiles use gpioget to see new gpios asserted.
Change-Id: I7a0a9d1b32d6cdb09da9b4eec761b5e06902681a
Reviewed-on: https://chromium-review.googlesource.com/231719
Commit-Queue: Todd Broch <tbroch@chromium.org>
Trybot-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/dingdong/board.c | 2 | ||||
| -rw-r--r-- | board/dingdong/gpio.inc | 1 | ||||
| -rw-r--r-- | board/hoho/board.c | 4 | ||||
| -rw-r--r-- | board/hoho/gpio.inc | 2 |
4 files changed, 9 insertions, 0 deletions
diff --git a/board/dingdong/board.c b/board/dingdong/board.c index 867eb1a4ed..cdeb95342c 100644 --- a/board/dingdong/board.c +++ b/board/dingdong/board.c @@ -105,6 +105,8 @@ static void board_init(void) hpd_prev_level = gpio_get_level(GPIO_DP_HPD); hpd_prev_ts = now.val; gpio_enable_interrupt(GPIO_DP_HPD); + + gpio_set_level(GPIO_STM_READY, 1); /* factory test only */ } DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT); diff --git a/board/dingdong/gpio.inc b/board/dingdong/gpio.inc index 72a96f9e1f..95a75b88b1 100644 --- a/board/dingdong/gpio.inc +++ b/board/dingdong/gpio.inc @@ -6,6 +6,7 @@ */ GPIO(DP_HPD, A, 0, GPIO_INT_BOTH, hpd_event) GPIO(USB_C_CC1_PD, A, 1, GPIO_ANALOG, NULL) +GPIO(STM_READY, A, 2, GPIO_OUT_LOW, NULL) /* factory test only */ GPIO(PD_DAC_REF, A, 4, GPIO_ANALOG, NULL) GPIO(DP_AUX_N, A, 5, GPIO_INPUT, NULL) GPIO(DP_AUX_P, A, 6, GPIO_INPUT, NULL) diff --git a/board/hoho/board.c b/board/hoho/board.c index d442d132a9..406bdebd77 100644 --- a/board/hoho/board.c +++ b/board/hoho/board.c @@ -142,6 +142,10 @@ static void board_init(void) hpd_prev_level = gpio_get_level(GPIO_DP_HPD); hpd_prev_ts = now.val; gpio_enable_interrupt(GPIO_DP_HPD); + + gpio_set_level(GPIO_STM_READY, 1); /* factory test only */ + /* TODO(crosbug.com/p/34122): Add real check for MCDP function */ + gpio_set_level(GPIO_MCDP_READY, 1); /* factory test only */ } DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT); diff --git a/board/hoho/gpio.inc b/board/hoho/gpio.inc index faa26dba27..4bd01192a3 100644 --- a/board/hoho/gpio.inc +++ b/board/hoho/gpio.inc @@ -6,9 +6,11 @@ */ GPIO(DP_HPD, A, 0, GPIO_INT_BOTH, hpd_event) GPIO(USB_C_CC1_PD, A, 1, GPIO_ANALOG, NULL) +GPIO(STM_READY, A, 2, GPIO_OUT_LOW, NULL) /* factory test only */ GPIO(MCDP_RESET_L, A, 3, GPIO_OUT_HIGH, NULL) GPIO(PD_DAC_REF, A, 4, GPIO_ANALOG, NULL) +GPIO(MCDP_READY, A, 7, GPIO_OUT_LOW, NULL) /* factory test only */ GPIO(PD_SBU_ENABLE, A, 8, GPIO_OUT_LOW, NULL) GPIO(USB_DM, A, 11, GPIO_ANALOG, NULL) GPIO(USB_DP, A, 12, GPIO_ANALOG, NULL) |