diff options
author | Duncan Laurie <dlaurie@chromium.org> | 2015-01-26 10:04:22 -0800 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-01-27 01:59:37 +0000 |
commit | a765485d7713b5c7a9b9822fd65f92922e13c74d (patch) | |
tree | b5a22a7c5a914b279373bc7645089068d3069c1b | |
parent | e768086fcf23ced14ce149e7593c478f8cc91b93 (diff) | |
download | chrome-ec-a765485d7713b5c7a9b9822fd65f92922e13c74d.tar.gz |
samus: Do not put touchscreen in reset based on lid switch
If we put the touchscreen in reset solely based on the lid state then
we do not allow the kernel driver to properly save and restore controller
state when entering suspend from a lid close event.
Since we want to always have touchscreen in reset in suspend/off state
and not in reset when the system is on then we can just remove this hook
because there is already logic in power_handle_state for that behavior.
BUG=chrome-os-partner:35879
BRANCH=samus
TEST=manual testing on samus:
1) put the device to sleep with lid open and powerd_dbus_suspend,
verify that TOUCHSCREEN_RESET_L=0
2) put the device to sleep with lid close and verify that
TOUCHSCREEN_RESET_L=0
3) check for kernel errors to ensure that there are no issues
saving touchscreen controller registers in the suspend path.
Change-Id: I5bff6356c54f064879a164e9ad4e67f1b2bcce6a
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/243242
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Sameer Nanda <snanda@chromium.org>
Commit-Queue: Alec Berg <alecaberg@chromium.org>
-rw-r--r-- | board/samus/power_sequence.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/board/samus/power_sequence.c b/board/samus/power_sequence.c index 79bd6d6783..eddddcc0a6 100644 --- a/board/samus/power_sequence.c +++ b/board/samus/power_sequence.c @@ -175,18 +175,6 @@ enum power_state power_chipset_init(void) return POWER_G3; } -static void update_touchscreen(void) -{ - /* - * If the lid is closed; put the touchscreen in reset to save power. - * If the lid is open, take it out of reset so it can wake the - * processor (although just opening the lid should do that anyway, so - * we don't have to worry about it staying on while the AP is off). - */ - gpio_set_level(GPIO_TOUCHSCREEN_RESET_L, lid_is_open()); -} -DECLARE_HOOK(HOOK_LID_CHANGE, update_touchscreen, HOOK_PRIO_DEFAULT); - enum power_state power_handle_state(enum power_state state) { struct batt_params batt; |