summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVincent Palatin <vpalatin@chromium.org>2015-05-27 09:32:38 -0700
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2015-05-27 21:30:25 +0000
commit245ee9f8d97e9eea8b99ab3c56ac8249cc256fec (patch)
tree1e3105cc836af7ca835ba984b81501b032a982f1
parenta2075a54307249255c055067a33fdfbaa3b0f66c (diff)
downloadchrome-ec-245ee9f8d97e9eea8b99ab3c56ac8249cc256fec.tar.gz
pd: never answer malformed VDM
When we are receiving a VDM which seems malformed, don't try to send an answer, else we can ping-pong broken messages with the other side. Signed-off-by: Vincent Palatin <vpalatin@chromium.org> BRANCH=none BUG=none TEST=plug Ryu P6 to plankton, no longer see endless "ERR:CMDT:1" error messages. Change-Id: If5b581c5c68996c60e37ac6d96638fd5df24356f Reviewed-on: https://chromium-review.googlesource.com/273525 Reviewed-by: Todd Broch <tbroch@chromium.org> Tested-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org> Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
-rw-r--r--common/usb_pd_policy.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/common/usb_pd_policy.c b/common/usb_pd_policy.c
index 36ecba8fc6..19c69a7369 100644
--- a/common/usb_pd_policy.c
+++ b/common/usb_pd_policy.c
@@ -726,6 +726,8 @@ int pd_svdm(int port, int cnt, uint32_t *payload, uint32_t **rpayload)
#endif /* CONFIG_USB_PD_ALT_MODE_DFP */
} else {
CPRINTF("ERR:CMDT:%d\n", cmd);
+ /* do not answer */
+ rsize = 0;
}
return rsize;
}