diff options
| author | Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> | 2015-05-30 10:31:53 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-06-04 01:15:44 +0000 |
| commit | 7b5c67609f69998f7bff163f6cea3931ac31f5ed (patch) | |
| tree | 353a5c0d118e99275c70f8ed0287cab8a3eaebc9 | |
| parent | 157543b287b0391502f82b943722f8770dabc356 (diff) | |
| download | chrome-ec-7b5c67609f69998f7bff163f6cea3931ac31f5ed.tar.gz | |
Increase charger/console/hook stack sizes.
Charger task is overflowing and causing crash.
Increased charger task stack size by 128 bytes.
Also increased console/hook by 128 bytes as these
are also close to its limit.
BRANCH=None
BUG=chrome-os-partner:40766
TEST=1.Program EC image.
2. Run various tests to verify charger stack doesn't
overflow.
Change-Id: I6e350584508fa3a47769982b1e0cf3e3aea9ded6
Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/274204
Reviewed-by: Sheng-liang Song <ssl@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: Divya Jyothi <divya.jyothi@intel.com>
| -rw-r--r-- | board/cyan/ec.tasklist | 6 | ||||
| -rw-r--r-- | chip/mec1322/config_chip.h | 4 |
2 files changed, 7 insertions, 3 deletions
diff --git a/board/cyan/ec.tasklist b/board/cyan/ec.tasklist index ecad9795b8..3df59e4321 100644 --- a/board/cyan/ec.tasklist +++ b/board/cyan/ec.tasklist @@ -17,13 +17,13 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ - TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, HOOKS_TASK_STACK_SIZE) \ + TASK_ALWAYS(CHARGER, charger_task, NULL, CHARGER_TASK_STACK_SIZE) \ TASK_NOTEST(MOTIONSENSE, motion_sense_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(KEYPROTO, keyboard_protocol_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(HOSTCMD, host_command_task, NULL, TASK_STACK_SIZE) \ - TASK_ALWAYS(CONSOLE, console_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(CONSOLE, console_task, NULL, CONSOLE_TASK_STACK_SIZE) \ TASK_NOTEST(PORT80, port80_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(POWERBTN, power_button_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) diff --git a/chip/mec1322/config_chip.h b/chip/mec1322/config_chip.h index 1780e9a8d3..49131ec243 100644 --- a/chip/mec1322/config_chip.h +++ b/chip/mec1322/config_chip.h @@ -73,6 +73,10 @@ #define IDLE_TASK_STACK_SIZE 512 #define LARGER_TASK_STACK_SIZE 640 +#define CHARGER_TASK_STACK_SIZE 640 +#define HOOKS_TASK_STACK_SIZE 640 +#define CONSOLE_TASK_STACK_SIZE 640 + /* Default task stack size */ #define TASK_STACK_SIZE 512 |