diff options
| author | Randall Spangler <rspangler@chromium.org> | 2015-08-03 15:18:16 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-08-04 02:18:39 +0000 |
| commit | 23aa59d35f806d8b35357ce9ad92fb3ecfce2b65 (patch) | |
| tree | c3e72c5535d006be09dc3b79df52e6e81458abef | |
| parent | 5dde4729511b55e169ee1d902ecdd469a71f3c0c (diff) | |
| download | chrome-ec-23aa59d35f806d8b35357ce9ad92fb3ecfce2b65.tar.gz | |
npcx: Fix termination of chip revision
system_get_chip_revision() would return a string which lacked the
terminating null. Increase the string length and enforce termination.
BUG=chromium:511405
BRANCH=none
TEST=version; should show chip revision without garbage chars at end
Change-Id: Icb9e36c5bfdf7de7400e5316934ccf28b4b57898
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/290392
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Mulin Chao <mlchao@nuvoton.com>
Tested-by: Mulin Chao <mlchao@nuvoton.com>
| -rw-r--r-- | chip/npcx/system.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chip/npcx/system.c b/chip/npcx/system.c index 2a872d0b66..973cb84c0c 100644 --- a/chip/npcx/system.c +++ b/chip/npcx/system.c @@ -541,7 +541,7 @@ const char *system_get_chip_name(void) const char *system_get_chip_revision(void) { - static char rev[4]; + static char rev[5]; /* Read ROM data for chip revision directly */ uint8_t rev_num = *((uint8_t *)CHIP_REV_ADDR); @@ -549,6 +549,7 @@ const char *system_get_chip_revision(void) *(rev + 1) = '.'; *(rev + 2) = system_to_hex((rev_num & 0xF0) >> 4); *(rev + 3) = system_to_hex(rev_num & 0x0F); + *(rev + 4) = '\0'; return rev; } |