diff options
| author | Todd Broch <tbroch@chromium.org> | 2015-08-12 20:57:38 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2015-08-27 11:45:57 -0700 |
| commit | 5bc9b3280765211deec626e25105c73c2ebb3e94 (patch) | |
| tree | 00aa791ff3cbc94ad0935c342eeddb0ad619f852 | |
| parent | 6ebc6c493fdb79398820a3b521f496cca901ff4a (diff) | |
| download | chrome-ec-5bc9b3280765211deec626e25105c73c2ebb3e94.tar.gz | |
ryu: Change charger termination current to 192mA.
Good rule of thumb for charger current is that it should be set
between C/20 & C/50 for the battery of the device.
For ryu its presently set at 64mA which may explain why we see
charger's status as charging even when battery is full. In any case
its well below recommendation so lets change it to something within
that.
Sampled data (see issue tracker) indicates charging current is ~256mA
when battery reaches 100% charged. Setting to 192mA (3 * 64) to error
on the side of charging slightly longer. This number is still within
termination current recommendation:
C/20 > term_current >= C/50
Note, also changing bq2589x default termination to match its POR value
of 256 as no other board uses this charger presently.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=smaug
BUG=chrome-os-partner:42848
TEST=manual, read charger IC termination register and see termination
current set to 192mA
Change-Id: I60dbb9326c3abb8091fd9ab18eda08b9eabb197b
Reviewed-on: https://chromium-review.googlesource.com/293096
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/ryu/board.h | 1 | ||||
| -rw-r--r-- | driver/charger/bq2589x.h | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/board/ryu/board.h b/board/ryu/board.h index 3b411ffda6..c1649e67fa 100644 --- a/board/ryu/board.h +++ b/board/ryu/board.h @@ -24,6 +24,7 @@ #define CONFIG_CHARGE_MANAGER #define CONFIG_CHARGE_MANAGER_EXTERNAL_POWER_LIMIT #define CONFIG_CHARGE_RAMP_HW +#define CONFIG_CHARGER_TERM_CURRENT_LIMIT (64*3) #define CONFIG_FORCE_CONSOLE_RESUME #define CONFIG_STM_HWTIMER32 #define CONFIG_USB_CHARGER diff --git a/driver/charger/bq2589x.h b/driver/charger/bq2589x.h index 8678816a6c..970517f116 100644 --- a/driver/charger/bq2589x.h +++ b/driver/charger/bq2589x.h @@ -69,7 +69,7 @@ #define BQ2589X_IR_COMP_DEFAULT (BQ2589X_IR_TREG_120C | BQ2589X_IR_VCLAMP_0MV |\ BQ2589X_IR_BAT_COMP_0MOHM) -#define BQ2589X_TERM_CURRENT_LIMIT_DEFAULT 64 +#define BQ2589X_TERM_CURRENT_LIMIT_DEFAULT 256 /* 5V VBUS Boost settings */ #define BQ2589X_BOOSTV_MV(mv) (((((mv) - 4550)/64) & 0xF) << 4) |