diff options
author | Vincent Palatin <vpalatin@chromium.org> | 2015-10-23 14:42:09 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2015-10-23 19:29:26 -0700 |
commit | 3f567a98698728b8688d5e5f539c976213834dd0 (patch) | |
tree | b1e2b90b303076644542f5251eed2c631f1fda4c | |
parent | b3911e8eeffe128187fc03c0e5faaa8dabe6752f (diff) | |
download | chrome-ec-3f567a98698728b8688d5e5f539c976213834dd0.tar.gz |
ryu: fix lid close detection
Now we are using LID_OPEN *and* BASE_PRES_L for lid close detection,
we need an interrupt on both to debounce arbitrarily long delay between
the transitions of the 2 GPIOs.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=smaug
BUG=chrome-os-partner:46189
TEST=manual: activate manually LID_OPEN and BASE_PRES_L hall sensors in
very slow sequences and see the proper "lid close"/"lid open" traces,
whatever sequence I do.
Reviewed-on: https://chromium-review.googlesource.com/308513
Trybot-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit 659d826b4efcd391eced3d4dda319d502d028457)
Change-Id: I2ee91370205a4bfc0f4b4d224cb55207f745af25
Reviewed-on: https://chromium-review.googlesource.com/308515
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Alec Berg <alecaberg@chromium.org>
-rw-r--r-- | board/ryu/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/ryu/gpio.inc b/board/ryu/gpio.inc index a81d6d6c59..ae59c63c24 100644 --- a/board/ryu/gpio.inc +++ b/board/ryu/gpio.inc @@ -10,6 +10,7 @@ GPIO_INT(CHGR_ACOK, PIN(D, 4), GPIO_INT_BOTH, vbus_evt) GPIO_INT(POWER_BUTTON_L, PIN(C, 13), GPIO_INT_BOTH, power_button_interrupt) /* active high, the name is for compatibility with existing code */ GPIO_INT(USBC_BC12_INT_L, PIN(D, 11), GPIO_INT_FALLING | GPIO_PULL_UP, usb_evt) GPIO_INT(LID_OPEN, PIN(E, 1), GPIO_INT_BOTH | GPIO_PULL_UP, lid_interrupt) +GPIO_INT(BASE_PRES_L, PIN(E, 10), GPIO_INT_BOTH | GPIO_PULL_UP, lid_interrupt) GPIO_INT(CHARGE_DONE, PIN(E, 6), GPIO_INT_BOTH, inductive_charging_interrupt) GPIO_INT(AP_IN_SUSPEND, PIN(F, 9), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(AP_HOLD, PIN(E, 3), GPIO_INT_BOTH, power_signal_interrupt) @@ -20,7 +21,6 @@ GPIO_INT(ALS_PROXY_INT_L, PIN(E, 15), GPIO_INT_FALLING | GPIO_PULL_UP, si11 GPIO(BC_TEMP_ALERT_L, PIN(C, 5), GPIO_INT_FALLING) GPIO(LB_INT_L, PIN(C, 14), GPIO_INT_FALLING | GPIO_PULL_UP) GPIO(LIGHTBAR_EN_L, PIN(E, 8), GPIO_INT_FALLING | GPIO_PULL_UP) -GPIO(BASE_PRES_L, PIN(E, 10), GPIO_INT_BOTH | GPIO_PULL_UP) GPIO(CHGR_INT_L, PIN(B, 2), GPIO_INT_FALLING) GPIO(CAM_SYNC_INT_L, PIN(C, 7), GPIO_INT_FALLING) GPIO(COMPASS_DRDY, PIN(A, 8), GPIO_INPUT) |