diff options
| author | Todd Broch <tbroch@chromium.org> | 2015-05-20 16:23:11 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-05-22 21:27:40 +0000 |
| commit | c2af47cd373ac3ff064886349f9835b272f00150 (patch) | |
| tree | 8be4b1f8f64e5450e717023bf651193afd124ed8 | |
| parent | 1a996dc19c82f9241226c8e6ff5f168d2c2c7ebc (diff) | |
| download | chrome-ec-c2af47cd373ac3ff064886349f9835b272f00150.tar.gz | |
mcdp28x0: Add info console command.
Would be useful to expose more of the GProbe commands to developers
who have access to boards console (hoho, honeybuns). This CL adds
a console command and seeds it the 'mcdp info' command.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=samus
BUG=chrome-os-partner:35939
TEST=manual, with CONFIG_CMD_MCDP defined in board/hoho/board.h
- Enter info console command multiple times and see correct
return value.
mcdp info
family:000e chipid:0001 irom:1.0.0 fw:0.0.0
Change-Id: Iaf2c088d5da1af7b2dab11abcfb6e32e289066ea
Reviewed-on: https://chromium-review.googlesource.com/272692
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
| -rw-r--r-- | driver/mcdp28x0.c | 38 | ||||
| -rw-r--r-- | include/config.h | 1 |
2 files changed, 33 insertions, 6 deletions
diff --git a/driver/mcdp28x0.c b/driver/mcdp28x0.c index a3a2043619..ded08975fb 100644 --- a/driver/mcdp28x0.c +++ b/driver/mcdp28x0.c @@ -158,11 +158,37 @@ int mcdp_get_info(struct mcdp_info *info) memcpy(info, &inbuf[2], MCDP_LEN_GETINFO); -#ifdef MCDP_DEBUG - CPRINTF("family:%04x chipid:%04x irom:%d.%d.%d fw:%d.%d.%d\n", - MCDP_FAMILY(info->family), MCDP_CHIPID(info->chipid), - info->irom.major, info->irom.minor, info->irom.build, - info->fw.major, info->fw.minor, info->fw.build); -#endif return EC_SUCCESS; } + +#ifdef CONFIG_CMD_MCDP +int command_mcdp(int argc, char **argv) +{ + int rv = EC_SUCCESS; + if (argc < 2) + return EC_ERROR_PARAM_COUNT; + + mcdp_enable(); + if (!strncasecmp(argv[1], "info", 4)) { + struct mcdp_info info; + rv = mcdp_get_info(&info); + if (!rv) + ccprintf("family:%04x chipid:%04x irom:%d.%d.%d " + "fw:%d.%d.%d\n", + MCDP_FAMILY(info.family), + MCDP_CHIPID(info.chipid), + info.irom.major, info.irom.minor, + info.irom.build, + info.fw.major, info.fw.minor, info.fw.build); + } else { + rv = EC_ERROR_PARAM1; + } + + mcdp_disable(); + return rv; +} +DECLARE_CONSOLE_COMMAND(mcdp, command_mcdp, + "info", + "USB PD", + NULL); +#endif /* CONFIG_CMD_MCDP */ diff --git a/include/config.h b/include/config.h index 5acc7d57ea..a824744896 100644 --- a/include/config.h +++ b/include/config.h @@ -374,6 +374,7 @@ #define CONFIG_CMD_IDLE_STATS #undef CONFIG_CMD_ILIM #undef CONFIG_CMD_JUMPTAGS +#undef CONFIG_CMD_MCDP #define CONFIG_CMD_PD #undef CONFIG_CMD_PD_DEV_DUMP_INFO #undef CONFIG_CMD_PD_FLASH |