diff options
| author | tonycwlin <tonycwlin@google.com> | 2016-05-19 14:30:57 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-05-19 06:05:57 -0700 |
| commit | 828d5c19f679e714a3ab3ec0f14fa478fa8eec50 (patch) | |
| tree | b31d2f841a3044daebbbf3aae20d2ebfb138478e | |
| parent | 35d534dfb37185118a735afccec5dc78d93fbc33 (diff) | |
| download | chrome-ec-828d5c19f679e714a3ab3ec0f14fa478fa8eec50.tar.gz | |
elm: Set internal pull-high to GPI pins below.
PE1 (BC12_ANX7688_INT_L)
PE7 (ANX7688_CABLE_DET_EC_L)
Cost down 2 resistors.
BUG=none
BRANCH=none
TEST=Measure this two pins and verify voltage with digital meter.
Change-Id: Ic4456d372171933b4ac45942dba9a28c5bd80d3d
Reviewed-on: https://chromium-review.googlesource.com/345746
Commit-Ready: Tony Lin <tonycwlin@google.com>
Tested-by: Tony Lin <tonycwlin@google.com>
Reviewed-by: Rong Chang <rongchang@chromium.org>
| -rw-r--r-- | board/elm/gpio.inc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/board/elm/gpio.inc b/board/elm/gpio.inc index 00e406dd09..7dbce4fde0 100644 --- a/board/elm/gpio.inc +++ b/board/elm/gpio.inc @@ -13,7 +13,7 @@ GPIO_INT(LID_OPEN, PIN(C, 13), GPIO_INT_BOTH, lid_interrupt) / GPIO_INT(SUSPEND_L, PIN(C, 7), GPIO_INT_BOTH, power_signal_interrupt) /* AP suspend/resume state */ GPIO_INT(SOC_POWER_GOOD, PIN(A, 3), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(PD_MCU_INT, PIN(E, 0), GPIO_INT_RISING, pd_mcu_interrupt) /* Signal from PD MCU, external pull-up */ -GPIO_INT(BC12_CABLE_INT, PIN(E, 1), GPIO_INT_FALLING, usb_evt) /* interrupt from BC12 and CABLE_DET */ +GPIO_INT(BC12_CABLE_INT, PIN(E, 1), GPIO_INT_FALLING | GPIO_PULL_UP, usb_evt) /* interrupt from BC12 and CABLE_DET */ GPIO_INT(POWER_BUTTON_L, PIN(B, 5), GPIO_INT_BOTH | GPIO_PULL_UP, power_button_interrupt) GPIO_INT(SPI1_NSS, PIN(A, 4), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) /* SPI Chip Select */ @@ -47,9 +47,9 @@ GPIO(KB_OUT12, PIN(D, 5), GPIO_KB_OUTPUT) /* Inputs without interrupt handlers */ GPIO(5V_POWER_GOOD, PIN(A, 1), GPIO_INPUT) -GPIO(EC_WAKE, PIN(A, 0), GPIO_INPUT|GPIO_PULL_DOWN) +GPIO(EC_WAKE, PIN(A, 0), GPIO_INPUT | GPIO_PULL_DOWN) GPIO(WP_L, PIN(B, 4), GPIO_INPUT) /* Write protect input */ -GPIO(BAT_PRESENT_L, PIN(E, 3), GPIO_INPUT|GPIO_PULL_UP) +GPIO(BAT_PRESENT_L, PIN(E, 3), GPIO_INPUT | GPIO_PULL_UP) GPIO(USB_C0_VBUS_WAKE_L, PIN(D, 12), GPIO_INPUT) GPIO(EC_INT_L, PIN(B, 9), GPIO_ODR_HIGH) @@ -70,7 +70,7 @@ GPIO(ENTERING_RW, PIN(F, 0), GPIO_OUT_LOW) GPIO(AP_RESET_L, PIN(C, 3), GPIO_ODR_HIGH) /* Connect to the PMU_SYSRSTB */ GPIO(BC12_WAKE_L, PIN(D, 7), GPIO_INPUT) -GPIO(USB_C0_CABLE_DET_L,PIN(E, 7), GPIO_INPUT) +GPIO(USB_C0_CABLE_DET_L,PIN(E, 7), GPIO_INPUT | GPIO_PULL_UP) GPIO(SYSTEM_POWER_H, PIN(B, 10), GPIO_OUT_LOW) GPIO(PMIC_PWRON_H, PIN(A, 12), GPIO_OUT_LOW) |