diff options
| author | Andrey Pronin <apronin@google.com> | 2016-06-10 18:01:53 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-06-11 13:21:34 -0700 |
| commit | 2698aba559975f402190e58c9a8dc6e3d5827e32 (patch) | |
| tree | 62e6512d73a37aabfeb1dc14bdb40eac0d115165 | |
| parent | 96fbb356871b3cf33efecf0936175cffb442c5b4 (diff) | |
| download | chrome-ec-2698aba559975f402190e58c9a8dc6e3d5827e32.tar.gz | |
tpm: allow less-than-4-bytes writes to TPM_STS register
Section 5.3.1 TPM Register Space Decode of TCG PC Client
Platform TPM Profile (PTP) Specification Rev 00.43 allows
partial access to registers: "Software may access only part
of a register, e.g. read or write one byte of a 4 byte register."
BUG=chrome-os-partner:54286
BRANCH=none
TEST=tpm driver successfully sets TPM_STS_COMMAND_READY
(see more details in BUG)
Change-Id: I92995f04c6f6221ab7e00d086c4067e447557476
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/351701
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
| -rw-r--r-- | common/tpm_registers.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/tpm_registers.c b/common/tpm_registers.c index e5d3b6e8df..1462022fc3 100644 --- a/common/tpm_registers.c +++ b/common/tpm_registers.c @@ -244,7 +244,7 @@ static void sts_reg_write_rr(void) */ static void sts_reg_write(const uint8_t *data, uint32_t data_size) { - uint32_t value; + uint32_t value = 0; data_size = MIN(data_size, 4); memcpy(&value, data, data_size); |