diff options
| author | Furquan Shaikh <furquan@google.com> | 2016-06-07 13:17:03 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-06-10 15:46:32 -0700 |
| commit | c12976b3121da197009d70fa3e0816293d1fb809 (patch) | |
| tree | 0d81f2586137e7abb3494d33e7874e79342fa1a0 | |
| parent | e1eb211f318b0d95cf7801ba49bebce51e290833 (diff) | |
| download | chrome-ec-c12976b3121da197009d70fa3e0816293d1fb809.tar.gz | |
reef: Add internal pull-up on LID_OPEN gpio
LID_OPEN gpio is present on the daughter card and provided by the
EC. Add an internal pull-up on it for the cases when the daughter card
isn't plugged in.
This fix won't be required starting EVT.
BUG=chrome-os-partner:54143, chrome-os-partner:53566
BRANCH=None
TEST=Compiles successfully. "gpioget LID_OPEN" returns 1 without
daughter card.
Change-Id: Ieff281b489e4f3f8be184a55b7975fb2efcc1099
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/350460
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | board/reef/gpio.inc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/board/reef/gpio.inc b/board/reef/gpio.inc index c7f3bc7336..db168126aa 100644 --- a/board/reef/gpio.inc +++ b/board/reef/gpio.inc @@ -23,7 +23,8 @@ GPIO_INT(ALL_SYS_PGOOD, PIN(5, 0), GPIO_INT_BOTH, power_signal_interrupt) /* P //GPIO_INT(AC_PRESENT, PIN(C, 1), GPIO_INT_BOTH | GPIO_INPUT, extpower_interrupt) /* ACOK_OD from BD99955 */ /* TODO: We might remove external pull-up for POWER_BUTTON_L in EVT */ GPIO_INT(POWER_BUTTON_L, PIN(0, 4), GPIO_INT_BOTH, power_button_interrupt) /* MECH_PWR_BTN_ODL */ -GPIO_INT(LID_OPEN, PIN(6, 7), GPIO_INT_BOTH, lid_interrupt) +/* FIXME(furquan): GPIO_PULL_UP is not required for LID_OPEN on EVT. */ +GPIO_INT(LID_OPEN, PIN(6, 7), GPIO_INT_BOTH | GPIO_PULL_UP, lid_interrupt) GPIO_INT(EC_VOLDN_BTN_L, PIN(8, 3), GPIO_INT_LOW | GPIO_PULL_UP, button_interrupt) GPIO_INT(EC_VOLUP_BTN_L, PIN(8, 2), GPIO_INT_LOW | GPIO_PULL_UP, button_interrupt) |