diff options
| author | Martin Roth <martinroth@chromium.org> | 2016-08-11 11:56:38 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-08-12 13:45:37 -0700 |
| commit | 7832ba6c4f9783d6ccb934b33028bb8adee07747 (patch) | |
| tree | c39192733d5ec29c132d270ea2ddedfdfcbb172e | |
| parent | de4d25964de310effe8ede09e5ba6fa2f40dc52b (diff) | |
| download | chrome-ec-7832ba6c4f9783d6ccb934b33028bb8adee07747.tar.gz | |
tcpm/anx74xx: initialize reg variable before use
When disabling auto_good_crc, the reg variable was being used
without initialization. Mirror the code for enabling auto_good_crc
to set the variable.
TEST=Booted reef with updated code.
BUG=None
BRANCH=None
Change-Id: Ie552f2ff74df05750bd65b6344d8a80cc285f8b0
Signed-off-by: Martin Roth <martinroth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/368221
Reviewed-by: David Hendricks <dhendrix@chromium.org>
| -rw-r--r-- | driver/tcpm/anx74xx.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index cdba2c8acb..0465a5179e 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -44,6 +44,8 @@ static void anx74xx_tcpm_set_auto_good_crc(int port, int enable) tcpc_read(port, ANX74XX_REG_TX_AUTO_GOODCRC_1, ®); reg |= ANX74XX_REG_AUTO_GOODCRC_EN; } else { + /* Clear bit-0 for disable */ + tcpc_read(port, ANX74XX_REG_TX_AUTO_GOODCRC_1, ®); reg &= ~ANX74XX_REG_AUTO_GOODCRC_EN; tcpc_write(port, ANX74XX_REG_TX_AUTO_GOODCRC_2, 0); } |