summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorli feng <li1.feng@intel.com>2016-08-03 15:56:25 -0700
committerchrome-bot <chrome-bot@chromium.org>2016-08-21 15:52:11 -0700
commita7c6942f73159c21bd34bc3c4844dcd0e15ef654 (patch)
treea08703506aa84ff4f595796945bb42eae8385264
parent46dc1727111cf0e891982110f5feaed0acda08c3 (diff)
downloadchrome-ec-a7c6942f73159c21bd34bc3c4844dcd0e15ef654.tar.gz
reef: add power led behavior
There is only one set LED in reef, so with charger attached, LED behave as charging LED; without charger, as power LED. BUG=chrome-os-partner:55492 BRANCH=none TEST=on reef proto, verified power led behavior is correct in s0/s3/g3 Change-Id: If6b83c46fc4b8b455531698177f559ca319d241a Signed-off-by: li feng <li1.feng@intel.com> Reviewed-on: https://chromium-review.googlesource.com/366102 Commit-Ready: Kevin K Wong <kevin.k.wong@intel.com> Tested-by: Li1 Feng <li1.feng@intel.com> Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r--board/reef/led.c69
1 files changed, 57 insertions, 12 deletions
diff --git a/board/reef/led.c b/board/reef/led.c
index 2380366d85..ad1a16b073 100644
--- a/board/reef/led.c
+++ b/board/reef/led.c
@@ -2,13 +2,14 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*
- * Power and battery LED control for Amenia.
+ * Power and battery LED control for Reef
*/
#include "battery.h"
#include "charge_state.h"
#include "chipset.h"
#include "ec_commands.h"
+#include "extpower.h"
#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
@@ -27,7 +28,8 @@
#define LED_ON_2SECS_TICKS 2
const enum ec_led_id supported_led_ids[] = {
- EC_LED_ID_BATTERY_LED};
+ EC_LED_ID_BATTERY_LED,
+ EC_LED_ID_POWER_LED};
const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids);
@@ -38,7 +40,7 @@ enum led_color {
LED_COLOR_COUNT /* Number of colors, not a color itself */
};
-static int bat_led_set_color(enum led_color color)
+static int set_color(enum led_color color)
{
switch (color) {
case LED_OFF:
@@ -65,20 +67,27 @@ void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range)
brightness_range[EC_LED_COLOR_AMBER] = 1;
}
-static int led_set_color_battery(enum led_color color)
+static inline int led_set_color_battery(enum led_color color)
{
- return bat_led_set_color(color);
+ return set_color(color);
+}
+
+static inline int led_set_color_power(enum led_color color)
+{
+ return set_color(color);
}
static int led_set_color(enum ec_led_id led_id, enum led_color color)
{
int rv;
-
led_auto_control(led_id, 0);
switch (led_id) {
case EC_LED_ID_BATTERY_LED:
rv = led_set_color_battery(color);
break;
+ case EC_LED_ID_POWER_LED:
+ rv = led_set_color_power(color);
+ break;
default:
return EC_ERROR_UNKNOWN;
}
@@ -97,6 +106,37 @@ int led_set_brightness(enum ec_led_id led_id, const uint8_t *brightness)
return EC_SUCCESS;
}
+static void led_set_power(void)
+{
+ static int power_ticks;
+ static int previous_state_suspend;
+
+ power_ticks++;
+ if (chipset_in_state(CHIPSET_STATE_SUSPEND)) {
+ /*
+ * Reset ticks if entering suspend so LED turns amber
+ * as soon as possible.
+ */
+
+ if (!previous_state_suspend)
+ power_ticks = 0;
+
+ /* Blink once every four seconds. */
+ led_set_color_power(
+ (power_ticks % LED_TOTAL_4SECS_TICKS)
+ < LED_ON_1SEC_TICKS ? LED_AMBER : LED_OFF);
+
+ previous_state_suspend = 1;
+ return;
+ }
+
+ previous_state_suspend = 0;
+ if (chipset_in_state(CHIPSET_STATE_ANY_OFF))
+ led_set_color_power(LED_OFF);
+ else if (chipset_in_state(CHIPSET_STATE_ON))
+ led_set_color_power(LED_BLUE);
+}
+
static void led_set_battery(void)
{
static int battery_ticks;
@@ -104,10 +144,6 @@ static void led_set_battery(void)
battery_ticks++;
- /* BAT LED behavior:
- * Same as the chromeos spec
- * Green/Amber for CHARGE_FLAG_FORCE_IDLE
- */
switch (charge_get_state()) {
case PWR_STATE_CHARGE:
led_set_color_battery(LED_AMBER);
@@ -150,10 +186,19 @@ static void led_set_battery(void)
}
}
-/** * Called by hook task every 1 sec */
+/* Called by hook task every 1 sec */
static void led_second(void)
{
- if (led_auto_control_is_enabled(EC_LED_ID_BATTERY_LED))
+ /*
+ * Reference board only has one LED, so overload it to act as both
+ * power LED and battery LED.
+ */
+ if (extpower_is_present() &&
+ led_auto_control_is_enabled(EC_LED_ID_BATTERY_LED))
led_set_battery();
+ else if (led_auto_control_is_enabled(EC_LED_ID_POWER_LED))
+ led_set_power();
+ else
+ set_color(LED_OFF);
}
DECLARE_HOOK(HOOK_SECOND, led_second, HOOK_PRIO_DEFAULT);