diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-09-19 16:41:39 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-21 19:37:51 -0700 |
| commit | 27a5f046320b9274b247f19ee339bbf7f787abe6 (patch) | |
| tree | a45c86cd736a6d891ea1d74f14146a86b2960ca7 | |
| parent | f5baf7e2180f89b682721e9e9fe8763d39917238 (diff) | |
| download | chrome-ec-27a5f046320b9274b247f19ee339bbf7f787abe6.tar.gz | |
npcx: shi: Clear EOR bit at start of legit transaction
Prevent EOR from cascading from one failed transaction to the next by
explicitly clearing it when CS is asserted.
BUG=chrome-os-partner:57563
BRANCH=Kevin
TEST=Package new EC image into recovery installer, verify recovery
completes without failure.
Change-Id: I44112f81cb712bb1e93fc10d2aff58f527e7a0fe
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/387236
Reviewed-by: Mulin Chao <mlchao@nuvoton.com>
(cherry picked from commit 50fc635fc8335df767e209488493d25e6548c641)
Reviewed-on: https://chromium-review.googlesource.com/387625
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | chip/npcx/shi.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chip/npcx/shi.c b/chip/npcx/shi.c index ccb0ad4e6f..449d932ba7 100644 --- a/chip/npcx/shi.c +++ b/chip/npcx/shi.c @@ -681,6 +681,12 @@ void shi_cs_event(enum gpio_signal signal) DEBUG_CPRINTF("CSL-"); /* + * Clear possible EOR event from previous transaction since it's + * irrelevant now that CS is re-asserted. + */ + SET_BIT(NPCX_EVSTAT, NPCX_EVSTAT_EOR); + + /* * Enable SHI interrupt - we will either succeed to parse our host * command or reset on failure from here. */ |