summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2017-01-01 20:58:15 -0800
committerchrome-bot <chrome-bot@chromium.org>2017-01-02 04:48:25 -0800
commit388d561d54f02b228f4be52902f2ec46e91f6577 (patch)
tree92a6855389e09ae226d45b289f38e1c30239d005
parent73d0b9ca9f57e2693e394e81d7d2ab27f348d613 (diff)
downloadchrome-ec-388d561d54f02b228f4be52902f2ec46e91f6577.tar.gz
eve: Enable CONFIG_PWM_KBLIGHT and fix volume buttons
- Enable keyboard backlight configuration option so the keyboard backlight interface is present. - Enable interrupt on both directions for volume buttons, otherwise we see the press but not the release. BUG=chrome-os-partner:58666 BRANCH=none TEST=manual testing on P1 board Change-Id: If0b6a913bb63f31051ab5a30ffe9f0682550e058 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://chromium-review.googlesource.com/424493 Reviewed-by: Hung-Te Lin <hungte@chromium.org>
-rw-r--r--board/eve/board.h1
-rw-r--r--board/eve/gpio.inc4
2 files changed, 3 insertions, 2 deletions
diff --git a/board/eve/board.h b/board/eve/board.h
index e266a29bdc..d5b93ae0ca 100644
--- a/board/eve/board.h
+++ b/board/eve/board.h
@@ -29,6 +29,7 @@
#define CONFIG_LID_SWITCH
#define CONFIG_LTO
#define CONFIG_PWM
+#define CONFIG_PWM_KBLIGHT
#define CONFIG_SPI_FLASH_REGS
#define CONFIG_SPI_FLASH_W25X40
#define CONFIG_UART_HOST 0
diff --git a/board/eve/gpio.inc b/board/eve/gpio.inc
index 172900781b..ffa47a85a1 100644
--- a/board/eve/gpio.inc
+++ b/board/eve/gpio.inc
@@ -18,8 +18,8 @@ GPIO_INT(PMIC_DPWROK, PIN(9, 7), GPIO_INT_BOTH, power_signal_interrupt)
GPIO_INT(POWER_BUTTON_L, PIN(0, 4), GPIO_INT_BOTH | GPIO_PULL_UP, power_button_interrupt)
GPIO_INT(LID_OPEN, PIN(6, 7), GPIO_INT_BOTH, lid_interrupt)
GPIO_INT(TABLET_MODE_L, PIN(3, 6), GPIO_INT_BOTH, tablet_mode_interrupt)
-GPIO_INT(VOLUME_DOWN_L, PIN(8, 3), GPIO_INT_FALLING | GPIO_PULL_UP, button_interrupt)
-GPIO_INT(VOLUME_UP_L, PIN(8, 2), GPIO_INT_FALLING | GPIO_PULL_UP, button_interrupt)
+GPIO_INT(VOLUME_DOWN_L, PIN(8, 3), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt)
+GPIO_INT(VOLUME_UP_L, PIN(8, 2), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt)
GPIO_INT(WP_L, PIN(4, 0), GPIO_INT_BOTH, switch_interrupt)
GPIO_INT(AC_PRESENT, PIN(C, 1), GPIO_INT_BOTH, extpower_interrupt)