summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@google.com>2017-04-28 08:29:26 +0800
committerchrome-bot <chrome-bot@chromium.org>2017-05-02 00:01:35 -0700
commitec04eabb0190afdbf6d3ebbb9419c16fe4f407f0 (patch)
treec5419f6b8e505206f370dff64d31ddc7b9902ac9
parent95139fa58280335f302827d96154038a7c23e0c0 (diff)
downloadchrome-ec-ec04eabb0190afdbf6d3ebbb9419c16fe4f407f0.tar.gz
usb_update: 1-byte response to extra commands
The existing commands do not really need longer response code. Future commands can always reply with more data as needed. BRANCH=none BUG=b:35587171 TEST=Update hammer using usb_updater2 Change-Id: I37cb8ac444d58216a7d98c9090043b06d95c74e1 Reviewed-on: https://chromium-review.googlesource.com/489887 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r--common/usb_update.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usb_update.c b/common/usb_update.c
index cf5850e53d..53aa9d09ae 100644
--- a/common/usb_update.c
+++ b/common/usb_update.c
@@ -141,7 +141,7 @@ static int try_vendor_command(struct consumer const *consumer, size_t count)
if (update_pdu_valid(&cmd_buffer->cmd,
count - offsetof(struct update_frame_header, cmd))) {
enum update_extra_command subcommand;
- uint16_t response;
+ uint8_t response;
size_t response_size = sizeof(response);
/* looks good, let's process it. */