diff options
| author | Duncan Laurie <dlaurie@google.com> | 2017-05-24 13:12:10 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-05-25 12:25:20 -0700 |
| commit | cb4ff83d5b14b1f845e0249159c41f44f51f40f1 (patch) | |
| tree | 1cd9692eb316996aaf9a73a21f052c05ee25b800 | |
| parent | dcedeab2cceac2eb2e5f1e29639cf0271283a18f (diff) | |
| download | chrome-ec-cb4ff83d5b14b1f845e0249159c41f44f51f40f1.tar.gz | |
eve: Implement workaround for broken reset flags
Newer Eve boards will lose VBAT on power cycle and therefore cannot
successfully save the reset flag state.
Implement the workaround that will allow these boards to continue to
work for FAFT testing by indicating to the skylake chipset power code
that it should skip the PMIC reset when doing 'reboot ap-off'.
BUG=b:35585876
BRANCH=none
TEST=manual testing on Eve: execute 'reboot ap-off' and ensure that the
AP does not power on. Also ensure that 'dut-control power_state:rec' works
as expected and does not power off at the recovery screen due to a power
button press.
Change-Id: Ida1563593d802c00280a55a0d24a504c25fab532
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://chromium-review.googlesource.com/514504
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
| -rw-r--r-- | board/eve/board.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/board/eve/board.c b/board/eve/board.c index 52f000a0d2..8fd65753a5 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -372,6 +372,18 @@ static void board_set_tablet_mode(void) tablet_set_mode(!gpio_get_level(GPIO_TABLET_MODE_L)); } +int board_has_working_reset_flags(void) +{ + int version = board_get_version(); + + /* board version >= P1b will lose reset flags on power cycle */ + if (version >= 3) + return 0; + + /* All other board versions should have working reset flags */ + return 1; +} + /* Initialize board. */ static void board_init(void) { |