diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2017-06-14 13:21:50 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-06-23 13:13:15 -0700 |
| commit | 7632f7c4ee958706a868b588985877a77976fd59 (patch) | |
| tree | 70c29e1a848ec00cf416df3b8f683b66594f28fd | |
| parent | 9069d0ff28b2a77dc5b8db3d8e968df12b9f275f (diff) | |
| download | chrome-ec-7632f7c4ee958706a868b588985877a77976fd59.tar.gz | |
genvif: Fix uninitialized variable access
Defects reported by Coverity.
BUG=None
TEST=`make buildall -j`
BRANCH=None
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I15e0809f8d97e75be522b6160346de6b59316395
Reviewed-on: https://chromium-review.googlesource.com/535837
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | util/genvif.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/util/genvif.c b/util/genvif.c index 50e4680e24..5cddd86327 100644 --- a/util/genvif.c +++ b/util/genvif.c @@ -232,7 +232,7 @@ static uint32_t bcddevice_sop(void) static uint32_t write_pdo_to_vif(FILE *vif, uint32_t pdo, enum dtype type, uint32_t pnum) { - uint32_t power; + uint32_t power = 0; if ((pdo & PDO_TYPE_MASK) == PDO_TYPE_FIXED) { uint32_t current = pdo & 0x3ff; @@ -291,6 +291,8 @@ static uint32_t write_pdo_to_vif(FILE *vif, uint32_t pdo, else fprintf(vif, "Snk_PDO_Op_Current%d: %d\r\n", pnum, current); + } else { + fprintf(stderr, "ERROR: Invalid PDO_TYPE %d.\n", pdo); } return power; @@ -485,8 +487,8 @@ int main(int argc, char **argv) { int nopt; int ret; - const char *out; - const char *board; + const char *out = NULL; + const char *board = NULL; const char *vif_producer; DIR *vifdir; char *name; |