diff options
| author | Scott Collyer <scollyer@google.com> | 2017-07-12 10:38:24 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-07-13 15:08:41 -0700 |
| commit | 6bcbc966cfa5d0f048824f827ca2825a1a1bf50e (patch) | |
| tree | 512505c5846860ea747db7b2db7416cbdd85207d | |
| parent | df09bc2c83c70716afcfd73e4eadf8cda0195848 (diff) | |
| download | chrome-ec-6bcbc966cfa5d0f048824f827ca2825a1a1bf50e.tar.gz | |
eve: Update static battery parameters for Simplo/LG packs
The Simplo_a50 battery had voltage_max = 8750 mV, which is not correct
and it should be 8800. Since the voltage_max parameter is used with
-0.5% margin, the 8750 mV value resulted in a charger setting of 8704
and does not provide enough of a voltage delta between the charger and
the battery to fully charge packs that exceed the design capacity.
In addition, had the tables for both battery types reviewed by the HW
team and updated some of the temperature parameters.
BUG=b:62483321
BRANCH=eve
TEST=Tested with a dogood unit that was failing to reach 100% charge
and showing very long "time to full" values as the battery charge
approached 90%. After adjusting the voltage_max param, tested and
verified that the battery reached 100% charge. In addition, verified
the bd9995x 0x1A register had the correct voltage setting.
Change-Id: I40e7bc111b048986e824fcb7843e57433a1def84
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/570380
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
| -rw-r--r-- | board/eve/battery.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/board/eve/battery.c b/board/eve/battery.c index e5cbd61271..0cb3a3bf1d 100644 --- a/board/eve/battery.c +++ b/board/eve/battery.c @@ -55,8 +55,8 @@ static const struct battery_info batt_info_lg = { .precharge_current = 256, /* mA */ .start_charging_min_c = 0, .start_charging_max_c = 46, - .charging_min_c = 0, - .charging_max_c = 60, + .charging_min_c = 10, + .charging_max_c = 50, .discharging_min_c = 0, .discharging_max_c = 60, }; @@ -67,7 +67,7 @@ static const struct battery_info batt_info_lg = { * limits are given by discharging_min/max_c. */ static const struct battery_info batt_info_lishen = { - .voltage_max = TARGET_WITH_MARGIN(8750, 5), /* mV */ + .voltage_max = TARGET_WITH_MARGIN(8800, 5), /* mV */ .voltage_normal = 7700, .voltage_min = 6100, /* Add 100mV for charger accuracy */ .precharge_current = 256, /* mA */ @@ -75,8 +75,8 @@ static const struct battery_info batt_info_lishen = { .start_charging_max_c = 46, .charging_min_c = 10, .charging_max_c = 50, - .discharging_min_c = 10, - .discharging_max_c = 50, + .discharging_min_c = 0, + .discharging_max_c = 60, }; static const struct board_batt_params info[] = { |