diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2019-11-27 10:51:44 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-12-02 13:35:27 +0000 |
| commit | a5a98e063de8a71ef6416986a5962e3f7a36e4ca (patch) | |
| tree | 6c6de1c250f97f4c8ec2d39855b54de626924fa8 | |
| parent | 4cead5fee84bd61494c24faabeca9106a1b274a6 (diff) | |
| download | chrome-ec-a5a98e063de8a71ef6416986a5962e3f7a36e4ca.tar.gz | |
i2c: don't output trace line for 0 length data
Write I2C operations always displayed a line indicating a
read of port:addr with nothing following. Just don't output
any lines that have no data to display.
BUG=none
BRANCH=none
TEST=i2ctrace should not display lines with no data
Change-Id: I1ba4bf3e627c47e62c68a592473431fcc195420a
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1940776
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | common/i2c_trace.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/common/i2c_trace.c b/common/i2c_trace.c index 06990cfa4f..d25f89a00c 100644 --- a/common/i2c_trace.c +++ b/common/i2c_trace.c @@ -29,6 +29,9 @@ void i2c_trace_notify(int port, uint16_t slave_addr_flags, size_t i; uint16_t addr = I2C_GET_ADDR(slave_addr_flags); + if (size == 0) + return; + for (i = 0; i < ARRAY_SIZE(trace_entries); i++) if (trace_entries[i].enabled && trace_entries[i].port == port |